Closed
Bug 493695
Opened 16 years ago
Closed 15 years ago
create accessibles for HTML tr
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
MarcoZ
:
review+
davidb
:
review+
|
Details | Diff | Splinter Review |
patch creates generic accessible for HTML tr and do not create accessibles for HTML thead, tbody, tfoot. We need to check how AT works with this.
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
try server build (create accessibles for HTML tr) - https://build.mozilla.org/tryserver-builds/surkov.alexander@gmail.com-1242716596/
try server build (create accessibles for HTML tr, do not create accessibles for thead, tbody, tfoot) - https://build.mozilla.org/tryserver-builds/surkov.alexander@gmail.com-1242716806/
|
||
Comment 3•16 years ago
|
||
Alex, right now, the accessibles don't get a proper role. They get an unknown role and a role string of "tr".
|
|
Assignee | |
Comment 4•16 years ago
|
||
Damn. Thank you, Marco. Could please check this one?
Attachment #378270 -
Attachment is obsolete: true
|
|
||
Comment 5•16 years ago
|
||
This one works much better! NVDA again sees the table contents, and JAWS seems unaffected by the change.
One question:
Is it wanted that each TR accessible gets the whole row's content as its accessible name? In other words, each cell's content is concatenated to one long string (with spaces) from all the text inside that row.
|
|
Assignee | |
Comment 6•16 years ago
|
||
(In reply to comment #5)
> One question:
> Is it wanted that each TR accessible gets the whole row's content as its
> accessible name? In other words, each cell's content is concatenated to one
> long string (with spaces) from all the text inside that row.
Iirc Rich said previously it shouldn't. It's another issue though.
|
|
Assignee | |
Comment 7•16 years ago
|
||
All screen reader vendors we work with are fine with this change. So create accessilbe for HTML tr, leave alone accessibles for thead and etc for now until we confirm we don't need them.
Attachment #378312 -
Attachment is obsolete: true
Attachment #378558 -
Flags: review?(marco.zehe)
Attachment #378558 -
Flags: review?(david.bolter)
|
||
Comment 8•16 years ago
|
||
Comment on attachment 378558 [details] [diff] [review]
patch3
r=me thanks!
Has anyone tried with Orca?
Attachment #378558 -
Flags: review?(david.bolter) → review+
|
|
||
Updated•16 years ago
|
Attachment #378558 -
Flags: review?(marco.zehe) → review+
|
|
||
Comment 9•16 years ago
|
||
Comment on attachment 378558 [details] [diff] [review]
patch3
r=me.
|
|
Assignee | |
Comment 10•16 years ago
|
||
(In reply to comment #8)
> (From update of attachment 378558 [details] [diff] [review])
> r=me thanks!
> Has anyone tried with Orca?
Afaik not yet, but Joanie said Orca uses table-cell-index object attribute so everything should be fine.
|
|
Assignee | |
Comment 11•15 years ago
|
||
Don't forget to mark bug 400539 worksforme once this one is landed.
|
|
Assignee | |
Comment 12•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•15 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•