1. Tools -> Options -> Privacy -> History 2. set "Minefield will: Remember history" or "Minefield will: Never remember history" 3. presss Tab key some time Actual Results: .inline-link cannot be selected with the keyboard. Expected Results: .inline-link can be selected with the keyboard.

Yeah, this needs to block as it's the only way to clear cookies now. David Bolter said that he'd look into it.

The easiest way to fix this is probably to add href="#" and "return false" to the onclick attribute.

(In reply to comment #2) > The easiest way to fix this is probably to add href="#" and "return false" to > the onclick attribute. Is the absence of an onclick making them unfocusable? I was tracking down: http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/privacy.xul#153 It looks like the links are inside a XUL <description> which I'm guessing is not expected to have focusable children. I was also thinking of adding moz-user-focus: normal to the inline-link class: http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/preferences/preferences.css#115 Dão, your knowledge and insight is welcome here. Thoughts?

Dão's suggestion in comment 2 works. I can prepare a patch shortly if you want me to.

(In reply to comment #4) > Dão's suggestion in comment 2 works. I can prepare a patch shortly if you want > me to. Ehsan, please go ahead! :)

Comment on attachment 379694 [details] [diff] [review] Patch (v1) I also went ahead and removed the redness from the links as well.

Comment on attachment 379694 [details] [diff] [review] Patch (v1) > cursor: pointer; Are you sure that's needed? >+.inline-link:focus { >+ outline: 1px dotted; > } And that?

I'm guessing here, but it seems that inline-link was created because text-link was undesirable? Here is text-link:focus (from global.css): .text-link:focus { border: 1px dotted -moz-DialogText; } What is the desired UI here?

Comment on attachment 379694 [details] [diff] [review] Patch (v1) From an accessibility standpoint, thumbs up.

(In reply to comment #8) > (From update of attachment 379694 [details] [diff] [review]) > > cursor: pointer; > > Are you sure that's needed? Actually not, a ua.css rule (*|*:-moz-any-link) seems to cover that. > >+.inline-link:focus { > >+ outline: 1px dotted; > > } > > And that? Yes, without that the ua.css rule (*|*:-moz-any-link:focus) gets overridden by the .inline-link rule. (In reply to comment #9) > I'm guessing here, but it seems that inline-link was created because text-link > was undesirable? Here is text-link:focus (from global.css): > > .text-link:focus { > border: 1px dotted -moz-DialogText; > } > > What is the desired UI here? I'm not really sure. Dão pointed out that outline is preferred over border... Dão, could you please weigh in?

(In reply to comment #11) > > >+.inline-link:focus { > > >+ outline: 1px dotted; > > > } > > > > And that? > > Yes, without that the ua.css rule (*|*:-moz-any-link:focus) gets overridden by > the .inline-link rule. So for the default outline, another option would be to use .inline-link:not(:focus) instead of .inline-link. > (In reply to comment #9) > > I'm guessing here, but it seems that inline-link was created because text-link > > was undesirable? Here is text-link:focus (from global.css): > > > > .text-link:focus { > > border: 1px dotted -moz-DialogText; > > } > > > > What is the desired UI here? > > I'm not really sure. Dão pointed out that outline is preferred over border... > Dão, could you please weigh in? Yes, outline is the right tool here (except that messes with layout incorrectly), and at some point text-link should use that too. As for the color, I don't think we really care whether it's -moz-DialogText or the actual text color (i.e. -moz-nativehyperlinktext).

Updated based on Dão's suggestions.

trunk: http://hg.mozilla.org/mozilla-central/rev/16336ebe1344

branch: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/77f2f7a17005

Verified fixed on trunk and 1.9.1 on all platforms with builds like; Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090529 Minefield/3.6a1pre ID:20090529031523 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090531 Shiretoko/3.5pre ID:20090531031205