Closed Bug 49974 Opened 24 years ago Closed 24 years ago

vlink attribute of Body tag fails.

Categories

(Core :: Layout, defect, P3)

Sun
All
defect

Tracking

()

VERIFIED DUPLICATE of bug 12493
mozilla0.8

People

(Reporter: nasiruddin.shaikh, Assigned: timeless)

References

()

Details

Attachments

(2 files)

After clicking the link, it takes user to the specified url. when we return to from there, the visited link doesn't show up in purple color.
Dividing up claytons bugs to triage.
Assignee: clayton → waqar
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: --- → Future
massive update for QA contact.
QA Contact: petersen → lorca
Hixie: can you fix this w/ a ua.css?
Keywords: qawanted
Nope. But since :visited is acting up as well, I think this is probably a bug with the Session History.
Whiteboard: suntrak-n6
I am seeing this on the PC, Windows 98 with Mozilla #2000120604.
OS: Solaris → All
Attached patch proposed fix (deleted) — Splinter Review
I'm attaching a patch for file nsStdURL.cpp. This seems to fix the bug. The problem was in different URL representation in href's. All host URL's stored in history have slashes on the end. A document may have link to this host without the closing slash. So when URL has "/" on the end, vlink attribute works well. The patch makes mozilla consider both URL spellings as the same (i.e. "http://www.cnn.com" and "http://www.cnn.com/"). On the other hand there is still a problem with href's when they point to host subdirectories (as http://www.cnn.com/countries). This problem seems to be inherited from Netscape 4.x. I don't know if to consider links like "http://www.cnn.com/countries" and "http://www.cnn.com/countries/" the same.
Attached patch revised version. no tabs. (deleted) — Splinter Review
Your patch seems to use tabs. We don't like tabs. here is the modeline: /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- This means that indents should be four spaces. Attached is a revised version. [Taking bug because waqar is overburdened]. This patch shares a variable w/ a later part of the same function and uses '/' instead of "/" which is consistent with the function. This patch is untested and assumes that the previous one works. Seeking testing, review and approval.
Assignee: waqar → timeless
Keywords: qawantedapproval, patch, review
Target Milestone: Future → mozilla0.8
fwiw countries and countries/ are not equivalent. If any patch makes them equivalent it should not be accepted. Actually, we probably need to just mark both links as visited. Either we make link mappings a => a/ and then resolve(a) => a/; check(a/) => visited, or just mark(a)=visited when we visit it. Come to think of it, I think this is a dupe.
Status: NEW → ASSIGNED
Keywords: qawanted
Whiteboard: suntrak-n6 → DUPEME suntrak-n6
Timeless, thanks for bringing that up. Yes, Its a DUPLICATE of #12493. -d *** This bug has been marked as a duplicate of 12493 ***
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
vrfy dupe. All status moved to original.
Status: RESOLVED → VERIFIED
Whiteboard: DUPEME suntrak-n6
SPAM. HTML Element component is deprecated, changing to Layout component. See bug 88132 for details.
Come on Bugzilla, you can do it...
Component: HTML Element → Layout
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: