Closed Bug 499766 Opened 15 years ago Closed 4 years ago

Warn when pasting whitespace into compose addressing area

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Thunderbird 73.0

People

(Reporter: clarkbw, Assigned: aleca)

References

Details

(Keywords: polish)

This is coming out of comments on bug 399329. We should have some way to warn people that they just pasted nothing into the address space. This is a pretty common error that occurs when a person does an empty copy that clears the clipboard and then pastes nothing by accident. I don't really want a popup dialog for this event, however some way of warning the person that they just pasted nothing or ' ' into the address space would be a really helpful thing. Ideas? The JS is fairly easy since the new gecko gives up the paste event. .addEventListener("paste", function() { alert("pasted"); }, false);

I've had this happen to me

Severity: normal → minor
Flags: needinfo?(alessandro)
Summary: warn on empty paste event → warn on empty paste event in compose addres list

Indeed, this should be part of address field.
As soon as the textbox conversion is completed, I'll start working on the refresh for the Address fields in the compose dialog (bug 440377).
I'll add this feature in the list of requirements for the revamped UI.

Flags: needinfo?(alessandro)
Assignee: nobody → alessandro

With the implementation of the new recipient pill on bug 440377, this issue doesn't prevent itself anymore as empty spaces are ignored and recipient pills are not created without a valid email address.
Can this be closed and set as resolved by bug 440377?

Flags: needinfo?(vseerror)

Thanks for fixing

Status: NEW → RESOLVED
Closed: 5 years ago
Depends on: tb-pills
Flags: needinfo?(vseerror)
Resolution: --- → FIXED
Whiteboard: [Fixed by bug 440377]
Target Milestone: --- → Thunderbird 73.0

(In reply to Alessandro Castellani (:aleca) from comment #3)

With the implementation of the new recipient pill on bug 440377, this issue doesn't prevsent itself anymore as empty spaces are ignored and recipient pills are not created without a valid email address.

Well, that's useful and we've polished that together but it's not the issue of this bug.
This is about warning the user about his mistake of pasting whitespace only. As no one in their right mind would deliberately paste whitespace only, the assumption is that they wanted to paste an address and accidentally failed. Imho, we should warn with a beep and a tooltip-style alert which disappears automatically after a second or so. Without warning, chances are that the user won't notice his error and might just send the message anyway with a missing recipient if it has other valid addresses.

Can this be closed and set as resolved by bug 440377?

Not implemented by bug 440377 and friends.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: warn on empty paste event in compose addres list → Warn on empty paste event in compose addressing area
Whiteboard: [Fixed by bug 440377]
Summary: Warn on empty paste event in compose addressing area → Warn when pasting whitespace into compose addressing area

An easy way of implementing this would be to use (XUL) <panel> or whatever the modern equivalent of that is. So it will show up unfocused with an arrow pointing at the offending spot, and we can make it disappear when the input changes, or user clicks anywhere.

I disagree with this.
We shouldn't treat the address row like a form field where the field turns red or shakes if you typed something wrong.
We have the pills and their visual feedback to show the user if something is not correct.
It shouldn't matter if the user is pasting white space because:

  • If they paste only white space, no pill is created, so it's pretty obvious that nothing happened.
  • If they paste a white space in between addresses, we ignore that and we handle the addressing format automatically, converting everything to pills.
  • Typing a white space at the start is not allowed in the field.

This is an extreme edge case that I don't think we had any report about issue for years.
For me this is a WONTFIX.
Magnus?

Flags: needinfo?(mkmelin+mozilla)

Agreed, I don't think we should to do anything about this.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
Flags: needinfo?(mkmelin+mozilla)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.