Closed Bug 501295 Opened 15 years ago Closed 15 years ago

Win32 test plugin position and clipping methods don't work

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(2 files)

Attached patch Part 1: fix pluginGetEdge (deleted) — Splinter Review
Currently test_plugin_position.xhtml skips Windows. It should test Windows. However, pluginGetEdge doesn't work right on Windows, it doesn't return coordinates relative to the window frame.
Attachment #385955 - Flags: review?(jmathies)
Attachment #385955 - Flags: review?(jmathies) → review+
Comment on attachment 385956 [details] [diff] [review] Part 2: compute accurate clip region nptest_platform.h comments need an update. but other than that this looks to be working correctly. I'm curious about how this test works. In test_plugin_position.xhtml it looks like you're creating an hbox that falls under the plugin, so the dimensions and clipping should be equal?
Attachment #385956 - Flags: review?(jmathies) → review+
The hbox is just a trick I'm using to determine whether 1 CSS pixel equals 1 screen pixel, and to figure out what the top-left of the document's viewport is relative to the top-left of the window frame decorations. It doesn't affect the plugin at all.
(In reply to comment #2) > (From update of attachment 385956 [details] [diff] [review]) > nptest_platform.h comments need an update. What do you mean?
Flags: in-testsuite+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: