There's a some brokenness in the standalone message window, especially with .eml files, most of it should be from bug 474701. - Open the View menu the security info isn't enabled/disabled properly An error occurred updating the cmd_viewSecurityStatus command gCurrentMessageUri is not defined We can use GetNumSelectedMessages for this, makes sense to have that as 1 for .eml files anyway. (And that's what it is for seamonkey.) While testing this i noticed, the context menu is not set up properly: Error: GetLoadedMsgFolder is not defined Source File: chrome://messenger/content/mailContextMenus.js Line: 175 I see now reason GetLoadedMsgFolder should exist anymore.... There was a warning about gThreadPaneDeleteOrMoveOccurred not defined, that variable is unused now since the refactoring. Yay! Also, going to the File | New menu in the standalone message window: Error: gFolderTreeView is null Source File: chrome://messenger/content/mailWindowOverlay.js Line: 94 --- This patch is on top of bug 506577 - didn't feel like bitrotting myself. Getting standar8 to sr the one-line mailnews/ change.

Comment on attachment 390785 [details] [diff] [review] proposed fix This passes the existing mozmill tests and an easy and useful set of tests to cover these cases doesn't jump out at me, but if any ideas for mozmill tests strike you, I won't complain :) >diff --git a/mail/base/content/mail3PaneWindowCommands.js b/mail/base/content/mail3PaneWindowCommands.js >@@ -348,24 +348,21 @@ var DefaultController = >+ return GetNumSelectedMessages() > 0 && gFolderDisplay.displayedFolder && >+ !gFolderDisplay.displayedFolder.isSpecialFolder( >+ Components.interfaces.nsMsgFolderFlags.Archive, true); You should use gFolderDisplay.selectedCount instead of GetNumSelectedMessages(). >diff --git a/mail/base/content/messageWindow.js b/mail/base/content/messageWindow.js >@@ -646,19 +646,19 @@ function OnUnloadMessageWindow() > function GetNumSelectedMessages() > { >- return gFolderDisplay.treeSelection.count; >+ return !gMessageDisplay.isDummy ? gFolderDisplay.treeSelection.count : 1; > } This should just directly return gFolderDisplay.selectedCount. messageWindow.js subclasses FolderDisplayWidget into StandaloneFolderDisplayWidget to make sure that it gets the right info. You could also change the callers to use gFolderDisplay.selectedCount instead if you so desire.

changeset: 3157:61b8d0d1af66 http://hg.mozilla.org/comm-central/rev/61b8d0d1af66 ->FIXED

Comment on attachment 390785 [details] [diff] [review] proposed fix Guess you forgot about the sr before checkin ;-) sr=Standard8 on the mailnews/ part anyway.

Yeah, thx!