--disable-compile-environment fails with a following error when trying to build a langpack for Firefox 3.6 on Ubuntu 9.04: checking for iwlib.h... no configure: error: Can't find header iwlib.h for Necko WiFi scanning (might be in package libiw-dev (Ubuntu) or wireless-tools-devel (Fedora)); use --disable-necko-wifi to disable *** Fix above errors and then restart with "make -f client.mk build" It doesn't happen for Firefox 3.5.

Probably this caused by Bug 503597

Yes, it is. Presumably the whole check for necko wifi should be inside some big ifdef conditioned on --disable-compile-environment?

It should probably be within the SKIP_LIBRARY_CHECKS block here: http://mxr.mozilla.org/mozilla-central/source/configure.in#4270 Although a handwritten COMPILE_ENVIRONMENT test would probably be ok as well.

Can we get this fixed? It's currently tripping one breed of builds on the l10n server, and I'd rather not have to work around this. Apart from being good to fix in general to make it easier for localizers to create local test builds on linux.

Does this fix it for you?

Comment on attachment 395366 [details] [diff] [review] patch This should work for --disable-compile-environment, but I'm not sure about the other changes. You dropped AC_SUBST, and the previous version made --disable-necko-wifi work for linux only and hardcoded it to be on for all but OS/2. Those changes should get an independent review.

Comment on attachment 395366 [details] [diff] [review] patch It was just restructuring the existing confusing logic into something equivalent that makes sense.