Closed
Bug 510177
Opened 15 years ago
Closed 15 years ago
firefox 3.5 does not render svg path element with one point
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: schwed, Assigned: longsonr)
References
Details
(Keywords: regression, testcase)
Attachments
(2 files, 3 obsolete files)
(deleted),
image/svg+xml
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
svg path element which consist only of one point (i.e. the d-attribute is like "M x,y Z") are no longer rendered. (Previous versions of FF has done it, also the Adobe svg viewer)
Reproducible: Always
Steps to Reproduce:
1.Create a svg file containing a path element like <path d="M x,y Z"/> where x, yare the coordinates of the point.
2.Examine the svg file withz FF3.5.2
3.
Actual Results:
You see nothing
Expected Results:
you should see a line consisting of one point
Assignee | ||
Comment 1•15 years ago
|
||
In which version did this work? Please upload a complete testcase using the Add an attachment link above.
Component: General → SVG
Product: Firefox → Core
QA Contact: general → general
Version: 3.5 Branch → unspecified
Assignee | ||
Comment 2•15 years ago
|
||
Looks like this has come up before (bug 322976)
Assignee | ||
Comment 4•15 years ago
|
||
In which version did this work?
Definitely since FF 3.0, I'm almost sure in FF 2.0 it worked too.
Comment 6•15 years ago
|
||
Yes, this used to work in FF3.
Assignee | ||
Comment 7•15 years ago
|
||
Assignee: nobody → longsonr
Attachment #409797 -
Flags: review?(jwatt)
Comment 8•15 years ago
|
||
Comment on attachment 409797 [details] [diff] [review]
patch
r=jwatt
Attachment #409797 -
Flags: review?(jwatt) → review+
Assignee | ||
Comment 9•15 years ago
|
||
Comment on attachment 409797 [details] [diff] [review]
patch
This is wrong. While you get some extents which allows drawing, they aren't the right ones.
Attachment #409797 -
Attachment is obsolete: true
Assignee | ||
Comment 10•15 years ago
|
||
Attachment #410337 -
Flags: review?(jwatt)
Updated•15 years ago
|
Attachment #410337 -
Flags: review?(jwatt) → review+
Comment 11•15 years ago
|
||
Comment on attachment 410337 [details] [diff] [review]
updated patch
r=jwatt, but please expand the comment:
// If 'extent' is empty, it's position will not be set. Although
// GetUserStrokeExtent gets the extents wrong we can still use it
// to get the device space position of zero length stroked paths.
Assignee | ||
Comment 12•15 years ago
|
||
Attachment #410337 -
Attachment is obsolete: true
Assignee | ||
Comment 13•15 years ago
|
||
checked in but then backed out again as it may have caused a smil reftest failure.
Assignee | ||
Comment 14•15 years ago
|
||
Assignee | ||
Comment 15•15 years ago
|
||
Attachment #418508 -
Attachment is obsolete: true
Assignee | ||
Comment 16•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 17•15 years ago
|
||
Patch must be cursed, since the (previously unknown or at least unfiled) failure in test_smilTextZoom.xhtml in http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261439943.1261442178.24825.gz looks suspiciously like you.
Assignee | ||
Comment 18•15 years ago
|
||
Clearly is cursed as it didn't fail this mochitest last time it landed. It needs backing out.
Comment 19•15 years ago
|
||
I think the mochitest is buggy actually. (I wrote it.)
This is an issue similar to bug 535850 -- the test has animations that begin at time=1s, and it assumes that the "onload" handler will fire before those animations begin. However, in extreme cases, it looks like the onload handler takes longer than a second to fire, so we're already partway through our timeline when we get to it.
This is a very low-probability random-orange. I'll push a fix for the test. (but even without the fix, it should probably go green in the next cycle)
Assignee | ||
Updated•15 years ago
|
Blocks: ietestcenter
You need to log in
before you can comment on or make changes to this bug.
Description
•