Closed Bug 51132 Opened 24 years ago Closed 24 years ago

Crash after pasting contents of compose window

Categories

(Core :: DOM: Editor, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: sfraser_bugs)

Details

(Keywords: crash)

Run mozilla -compose and type some status-report-type stuff into it with bulleted lists, e.g. Progress<hit return><click list>a<return>b<return><return>Plans<list>a<return>b<return><return> Select everything in the window by dragging the mouse, and paste it into another app, e.g. an xterm where you're doing cat >/dev/null. Note that the selection goes grey when you move the mouse out of the window. Now move the mouse back into the window. Insta-crash. Reproducible. This is probably crash that prevented me from filing my status report with mozilla last week (fortunately this week I was mistrustful and hit "Save" a lot, so this time I didn't lose data and may be able to pull it off). Stack trace: #0 0x42369658 in nsRemoveListCommand::IsCommandEnabled (this=0x8f3b7b8, aCommand=0x8c4e068, refCon=0x8f73bf8, outCmdEnabled=0xbfffbe44) at nsComposerCommands.cpp:478 #1 0x407fe750 in nsControllerCommandManager::IsCommandEnabled ( this=0x816d5a0, aCommandName=0x8c4e068, aCommandRefCon=0x8f73bf8, aResult=0xbfffbe44) at nsControllerCommandManager.cpp:116 #2 0x423634c4 in nsEditorController::IsCommandEnabled (this=0x8f76ee8, aCommand=0x8c4e068, aResult=0xbfffbe44) at nsEditorController.cpp:189 The offending line is: *outCmdEnabled = (*tagStr != nsnull); tagStr is 0. We need a check for tagStr here; or else nsEditorShell::GetListState needs to return an error if it's not going to set the tag string.
Should be dogfood: I've crashed two weeks out of two trying to file my status report (and the fix is easy, at least to make it not crash, though finding out why GetListState is returning an error might be harder).
Status: NEW → ASSIGNED
Keywords: crash, dogfood, nsbeta3
Target Milestone: --- → M18
2 bad things here; the crash, and a leak of tagStr. I'll fix.
Assignee: akkana → sfraser
Status: ASSIGNED → NEW
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Wow! I just found this today and fixed it in my tree!
verified in 10/31 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.