Currently, the default set of bookmarks use the no-favicon document icon. When they're bookmarks to pages on the internet, we should use those pages' real favicons. When they're to internal pages (like about:fennec) we could use a the product logo.

So, the list of favicons should be: Firefox: Welcome -- this goes to about:firstrun, for which the favicon should be the firefox logo Firefox: About -- this goes to about:firefox, so we'll use the Firefox logo again Firefox: Synchronize using Weave -- this page is part of the mozilla.com site, so we should use the mozilla.com dino head Firefox: Customize with add-ons -- goes to AMO, so use the AMO puzzle-piece Firefox: Support -- goes to mobile.SUMO, so use the SUMO favicon

this is what it looks like at the moment: http://www.flickr.com/photos/42739110@N07/3941675927/in/photostream/

The flickr link is marked private.

should work as of yesterday

This is harder than I thought it would be, because the places JSON import code doesn't support importing favicons. Adding that probably wouldn't be too hard (bug 423126 is related but mostly covers export).

Gavin: How much work do you think this is?

Not very much, turns out! I have a patch up in bug 518907.

fixed by bug 518907

not fixed by bug 518907

This patch has some issues: 1) Favicons are replaced by the crappier site version when you actually visit the web pages (sumo, AMO) 2) The Firefox logo is hardcoded and doesn't depend on branding. For 1), I think we want to just request that those sites use larger favicons. Shouldn't be much of an impact for them, and will make things look nicer in Fennec. I thought I could use a branding chrome:// URI to address 2), and added support in the importer for that, but the favicon service ignores icons for pages that aren't included in history, which includes about: pages. This means the branding chrome URI doesn't work to set the favicon, so I have to just hardcode the Firefox data: URI. We can probably work around that by making the faviconservice behavior here customizable in a followup. Note, this patch also tweaks a couple of URLs: - https://mobile.support.mozilla.com -> https://mobile.support.mozilla.com/@AB_CD@/kb/ to avoid a redirect, and to avoid multiple sumo entries being shown to the awesomebar after you actually visit the site. - https://www.mozilla.com/@AB_CD@/mobile/weave -> https://addons.mozilla.org/@AB_CD@/mobile/addon/10868 because the mozilla.com page doesn't exist, and there are no plans for it at this time (per Caitlin) Also renames favicon.png to favicon32.png (in preparation for fixing 2), and updates the Firefox version to use the with-shadow 32px version I got from faaborg.

Comment on attachment 410053 [details] [diff] [review] patch >diff --git a/app/mobile.js b/app/mobile.js >+// Let the faviconservice know that we display favicons as 24x24px so that it 32x32px

verified with 20091106 1.9.2 nightly on n810