Closed Bug 51942 Opened 24 years ago Closed 24 years ago

drag dup bookmark to a folder that contains its copy crashes

Categories

(SeaMonkey :: Bookmarks & History, defect, P2)

Tracking

(Not tracked)

VERIFIED WORKSFORME

People

(Reporter: cmaximus, Assigned: bugs)

Details

(Keywords: crash, Whiteboard: [nsbeta3-][RTM NEED INFO])

***Overview Description: Dragging a duplicate bookmark onto a folder that contains its copy crashes. ***Steps to Reproduce: 1) Bookmarks|Add Current Page. 2) Move that new bookmark to a different level in the hierarchy (put it in a folder). by whatever means necessary. 3) Bookmarks|Add Current Page, again. Drag the duplicate bookmark onto the folder that contains it's twin(careful, not *into* but onto the folder). ***Actual Results: Crash boom. ***Expected Results: Ideally, you should get the international symbol for 'NO' and not be allowed to complete the drag. Currently though, if you cut and paste instead of dragging the dupes are merged into one visible entry.(I think this leads to a large BM file). ***Build Date & Platform Info: Repro'd on Linux RH6 and Win98 with 2000090908 builds. Assuming Mac and marking ALL/ALL. ***Additional Information: Note this works fine if you drop into the folder list itself. It also works fine if you cut and paste, no matter where you paste. So I'm not blaming RDF but D&D code.
here's the talkback stack: all Stack: (Signature = FileSystemDataSource::isFileURI 5c22425d) FileSystemDataSource::isFileURI [d:\builds\seamonkey\mozilla\rdf\datasource\src\ nsFileSystemDataSource.cpp, line 208] FileSystemDataSource::HasArcOut [d:\builds\seamonkey\mozilla\rdf\datasource\src\ nsFileSystemDataSource.cpp, line 820] CompositeDataSourceImpl::HasArcOut [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp, line 1107] nsXULTemplateBuilder::CheckContainer [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULTemplateBuilder.cpp, line 6254] nsXULTemplateBuilder::SetContainerAttrs [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULTemplateBuilder.cpp, line 6656] nsXULTemplateBuilder::FireNewlyMatchedRules [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULTemplateBuilder.cpp, line 4662] nsXULTemplateBuilder::OnAssert [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULTemplateBuilder.cpp, line 4700] CompositeDataSourceImpl::OnAssert [d:\builds\seamonkey\mozilla\rdf\base\src\nsCompositeDataSource.cpp, line 1442] nsBookmarksService::OnAssert [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\ nsBookmarksService.cpp, line 4687] InMemoryDataSource::Assert [d:\builds\seamonkey\mozilla\rdf\base\src\nsInMemoryDataSource.cpp, line 1153] nsBookmarksService::Assert [d:\builds\seamonkey\mozilla\xpfe\components\bookmarks\src\ nsBookmarksService.cpp, line 2957] RDFContainerImpl::AppendElement [d:\builds\seamonkey\mozilla\rdf\base\src\nsRDFContainer.cpp, line 233] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\ xptcinvoke.cpp, line 139] nsXPCWrappedNativeClass::CallWrappedMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\ xpcwrappednativeclass.cpp, line 917] WrappedNative_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\ xpcwrappednativejsops.cpp, line 221] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 733] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2539] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 749] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 822] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3177] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 909] nsJSEventListener::HandleEvent [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 155] nsEventListenerManager::HandleEventSubType [d:\builds\seamonkey\mozilla\layout\events\src\ nsEventListenerManager.cpp, line 789] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\layout\events\src\ nsEventListenerManager.cpp, line 1509] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3307] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] PresShell::HandleEventInternal [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 4049] PresShell::HandleEvent [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 3979] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 379] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 352] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 352] nsViewManager2::DispatchEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager2.cpp, line 1429] HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 68] nsWindow::DispatchEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 618] nsNativeDragTarget::DispatchDragDropEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsNativeDragTarget.cpp, line 195] nsNativeDragTarget::ProcessDrag [d:\builds\seamonkey\mozilla\widget\src\windows\nsNativeDragTarget.cpp, line 217] nsNativeDragTarget::Drop [d:\builds\seamonkey\mozilla\widget\src\windows\nsNativeDragTarget.cpp, line 339] OLE32.DLL + 0x9de51 (0x65f9de51) OLE32.DLL + 0x5390d (0x65f5390d) OLE32.DLL + 0x53516 (0x65f53516) OLE32.DLL + 0x52f82 (0x65f52f82) OLE32.DLL + 0x534c2 (0x65f534c2) nsDragService::StartInvokingDragSession [d:\builds\seamonkey\mozilla\widget\src\windows\nsDragService.cpp, line 144] nsDragService::InvokeDragSession [d:\builds\seamonkey\mozilla\widget\src\windows\nsDragService.cpp, line 111] XPTC_InvokeByIndex [d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\ xptcinvoke.cpp, line 139] nsXPCWrappedNativeClass::CallWrappedMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\ xpcwrappednativeclass.cpp, line 917] WrappedNative_CallMethod [d:\builds\seamonkey\mozilla\js\src\xpconnect\src\ xpcwrappednativejsops.cpp, line 221] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 733] js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2539] js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 749] js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 822] JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3177] nsJSContext::CallEventHandler [d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 909] nsJSEventListener::HandleEvent [d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 155] nsEventListenerManager::HandleEventSubType [d:\builds\seamonkey\mozilla\layout\events\src\ nsEventListenerManager.cpp, line 789] nsEventListenerManager::HandleEvent [d:\builds\seamonkey\mozilla\layout\events\src\ nsEventListenerManager.cpp, line 1509] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3307] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326] nsXULElement::HandleDOMEvent [d:\builds\seamonkey\mozilla\rdf\content\src\nsXULElement.cpp, line 3326]
Severity: normal → major
Keywords: crash
Whiteboard: [nsbeta3-]
nav triage team: since this particular crash only happens if you have the same bookmark in 2 places then drag and drop one of them to the folder icon of the other one, then it crashes. Too rare, nsbeta3-
nominating for rtm. here's a straightforward easy to repro crash.
Keywords: rtm
Ben, will this be fixed by Steve Morse's patch for bug #53403.
Assignee: slamm → ben
Priority: P3 → P2
Whiteboard: [nsbeta3-] → [nsbeta3-][RTM NEED INFO]
Summary: dragging a duplicate bookmark onto a folder that contains its copy crashes → drag dup bookmark to a folder that contains its copy crashes
shorter summary
This now works for me (10/11 comm. build).. I assume something changed that fixed this majikally.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
mass-verifying WorksForMe bugs which haven't changed since 2001.12.31. set your search string in mail to "EmperorLondoMollari" to filter out these messages.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.