Open
Bug 51964
Opened 24 years ago
Updated 16 years ago
Should store Sidebar panels URL in properties file, not pref
Categories
(SeaMonkey :: Sidebar, defect)
SeaMonkey
Sidebar
Tracking
(Not tracked)
NEW
People
(Reporter: bugzilla, Unassigned)
Details
(Keywords: helpwanted)
In BrowseMorePanels() in customize.js, we currently do this:
var url = '';
var browser_url = "chrome://navigator/content/navigator.xul";
var prefs = Components.classes['component://netscape/preferences'];
if (prefs) {
prefs = prefs.getService();
}
if (prefs) {
prefs = prefs.QueryInterface(Components.interfaces.nsIPref);
}
if (prefs) {
var locale;
try {
url = prefs.CopyCharPref("sidebar.customize.more_panels.url");
var temp = prefs.CopyCharPref("browser.chromeURL");
if (temp) browser_url = temp;
} catch(ex) {
debug("Unable to get prefs: "+ex);
}
}
I don't see why we need an extra pref to store the URL that should be used.
The same thing can be accomplished more inefficiently by placing the URL in a
properties file and retrieving it via a string bundle. Presumably
brand.properties is the best place for this so the URL can change if necessary
between comm and mozilla builds.
Comment 1•24 years ago
|
||
I disagree. The channel list provider *is* a preference, see bug 52997. Also,
distributors are likely to change prefs anyway. Suggest WONTFIX.
Reporter | ||
Comment 2•24 years ago
|
||
->matt
I'm not sure I understand your reasoning; distributors are likely to change
brand.properties also, unless they plan on having their app say "Mozilla"
or "Netscape".
Assignee: slamm → matt
Comment 3•24 years ago
|
||
blake, distributors change both, so there's no advantage in having it in
.properties (apart from extremely minor perf). Users not being able to change it
is a major disadvantage, however. E.g. I don't like automatic netscape.com
queires, so I just disabled it completely by setting the pref to "". You would
remove this ability. Based on this, I am tempted to mark it WONTFIX myself, but
I will just strongly recommend it, for now.
Comment 5•23 years ago
|
||
Taking. Futuring.
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•16 years ago
|
Assignee: samir_bugzilla → nobody
Priority: P3 → --
QA Contact: sujay → sidebar
Target Milestone: Future → ---
Comment 6•16 years ago
|
||
This bug is being marked EXPIRED as it has seen no activity in a very long time.
If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.
http://www.seamonkey-project.org/
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → EXPIRED
Comment 7•16 years ago
|
||
This bug is being marked EXPIRED as it has seen no activity in a very long time.
If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.
http://www.seamonkey-project.org/
Comment 8•16 years ago
|
||
Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.
Status: RESOLVED → REOPENED
Resolution: EXPIRED → ---
Updated•16 years ago
|
Status: REOPENED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•