Closed
Bug 519884
Opened 15 years ago
Closed 15 years ago
NJ merge: nanojit-central configure.in and Makefile.in
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: graydon, Assigned: graydon)
References
Details
Attachments
(1 file)
(deleted),
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
The attached patch provides nanojit-central with its own configure.in and Makefile.in, as well as supporting files. It requires bug 519856 to work (at least when deriving from the TM head of n-c), and needs to be in a repository with both nanojit/ and vprof/, which I've added to the knitting script but haven't yet had a cset trigger.
Otherwise it lets you do out-of-tree, standard autoconf-y builds of nanojit and lirasm, and executes the lirasm tests, outputting results in the way our tinderbox parsers will want to see them. No dependence on TM or TR. Yay!
Comments welcome from people who know how to do this kind of stuff better than me. I'm always kinda flailing when it comes to configury.
Attachment #403934 -
Flags: review?(edwsmith)
Comment 1•15 years ago
|
||
For anyone reading the patch, config.guess, config.sub and install-sh are all autogenerated by automake, so you can presumably skip over them.
Comment 2•15 years ago
|
||
Comment on attachment 403934 [details] [diff] [review]
Yes, it contains autoconf. Shield your eyes.
nothing obviously wrong. i'll try it out for real when the patch's dependencies land
Attachment #403934 -
Flags: review?(edwsmith) → review+
Comment 3•15 years ago
|
||
oh, does Makefile.in need a copyright header?
Assignee | ||
Comment 4•15 years ago
|
||
Sure, yeah. I'll call it part of Nanojit Build System, boilerplate it up. Just waiting on a bit of review from jimb regarding the kludging of VMPI this depends on.
Assignee | ||
Updated•15 years ago
|
Assignee | ||
Comment 5•15 years ago
|
||
Not the world's most stable revision ID, I'll grant. But assuming no more repository-rebuilds (tenuous assumption) it landed here:
http://hg.mozilla.org/users/graydon_mozilla.com/nanojit-central/rev/968bafe874d9
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•