Closed
Bug 52007
Opened 24 years ago
Closed 22 years ago
Menu accelerators don't work if alt held down
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.2alpha
People
(Reporter: jruderman, Assigned: jruderman)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
akkzilla
:
review+
kinmoz
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
(alt-e), a works (selects everything on the page)
alt-(e,a) doesn't.
Furthermore, if there is an alt-A accesskey on the page, alt-(e,a) activates
the accesskeyed element.
Another observation that may or may not be the same problem: pressing alt-e,a
quickly doesn't work. I'm not sure if I'm lifting the alt key before or after
pressing 'a' in this case.
Mozilla nightly build 2000090908 on Win98.
Comment 1•24 years ago
|
||
This isn't a problem in the event system (at least, it's not known to be).
Moving to XPMenus.
Assignee: joki → pinkerton
Component: Event Handling → XP Toolkit/Widgets: Menus
QA Contact: janc → jrgm
Comment 2•24 years ago
|
||
I see what you mean, but no time for this in the current release cycle ->Future
Target Milestone: --- → Future
I think hyatt made a change last week so that one must be explicit in what
modifiers are allowed for different actions (like key presses and mouse clicks)
to go through the filters. I think I read about this in n.p.m.xpfe.
Assignee | ||
Comment 4•24 years ago
|
||
adding hyatt per heikki's comment
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.0
Updated•24 years ago
|
Target Milestone: mozilla1.0 → Future
Assignee | ||
Comment 5•24 years ago
|
||
Nominating for nsbeta1 because this slows me down in an annoying way when I'm
using menus with the keyboard. Also adding access keyword and ccing aaronl.
Comment 6•24 years ago
|
||
C'est moi.
Comment 7•24 years ago
|
||
Hyatt, can you expand on Heikki's comments at all? The Alt+<key> press isn't
getting to the menu listener. I've been trying to track this down, but haven't
had much luck yet. Oh wait, no, I haven't had _any_ luck yet.
Assignee | ||
Comment 9•23 years ago
|
||
I run into this bug frequently, because I've memorized several menu shortcuts
and can hit them quickly enough that it's hard to hold Alt down for just the
right amount of time.
Comment 10•23 years ago
|
||
In a little more detail, the problem that I mentioned before is that
nsMenuListener::KeyPress() doesn't get called if Alt is down. If Alt isn't
down, everything gets called as expected. Anyone care to figure out why? I'll
take another shot at it, but from what I remember from last time I had
absolutely no luck.
Comment 11•23 years ago
|
||
*** Bug 146662 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
Hrm. Maybe it's getting eaten by the menu bar listener.
Comment 13•23 years ago
|
||
Sorry; I'm no Mozilla hacker. But is it anything to do with an earlier fix,
resulting in version 1.51, to solve bug 71326?
Assignee | ||
Comment 14•22 years ago
|
||
*** Bug 147297 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•22 years ago
|
||
Yes, it's getting eaten by the menu bar listener and by page accesskeys. Alt+EF
opens the edit menu and then opens the file menu. Also, Alt+DZ at
http://www.cs.hmc.edu/~jruderma/s/ goes to Mozillazine (Alt+Z is an accesskey in
the page).
Assignee | ||
Comment 16•22 years ago
|
||
*** Bug 140392 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 17•22 years ago
|
||
I have a fix. nsMenuListener::KeyPress wasn't getting called because
nsMenuListener::KeyDown was dismissing the menu incorrectly. This fix is
similar to part of my fix for bug 79898, "Alt+key activates menu bar if alt
released before key": both patches remove the same section of code from
different files.
Fixing nsMenuListener::KeyDown fixes this bug but leaves the problem that page
accesskeys win over accesskeys in open menus. It's correct for page accesskeys
to win over accesskeys for main menu titles, but when a menu is open only the
menu should see key events. I'm still working on this problem.
Assignee: pinkerton → jruderman
Status: ASSIGNED → NEW
Assignee | ||
Comment 18•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Target Milestone: Future → mozilla1.2alpha
Comment 19•22 years ago
|
||
Comment on attachment 91160 [details] [diff] [review]
patch: fixes the bug except for when the page has accesskeys
r=akkana, but please update the "Since a menu is open" comment since when we
dismiss the menu we still get there.
Attachment #91160 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Comment 20•22 years ago
|
||
*** Bug 165314 has been marked as a duplicate of this bug. ***
Comment 21•22 years ago
|
||
Comment on attachment 91160 [details] [diff] [review]
patch: fixes the bug except for when the page has accesskeys
sr=kin@netscape.com
Attachment #91160 -
Flags: superreview+
Comment 22•22 years ago
|
||
Comment on attachment 91160 [details] [diff] [review]
patch: fixes the bug except for when the page has accesskeys
a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #91160 -
Flags: approval+
Comment 23•22 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•