Closed Bug 520371 Opened 15 years ago Closed 15 years ago

Bug 459457 moved dlgtype="help" rules in to the wrong stylesheet

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Proposed patch
(deleted), patch
dao
: review+
dveditz
: approval1.9.2.4+
Details | Diff | Splinter Review
The dlgtype="help" rules, which were originally in global.css, were moved to dialog.css, but that means they only get applied to anonymous dialog buttons and not explicit buttons any more. Moving the rules to button.css should ensure that they get applied correctly. See bug 515227 for how we worked around this.
Attached patch Proposed patch (deleted) — — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #404423 - Flags: review?(dao)
Attachment #404423 - Flags: review?(dao) → review+
Pushed changeset b44dd220dc15 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 404423 [details] [diff] [review] Proposed patch Regression fix to make explicit help dialog buttons work again.
Attachment #404423 - Flags: approval1.9.2?
Comment on attachment 404423 [details] [diff] [review] Proposed patch Pushing approval request for this regression fix to the next branch release.
Comment on attachment 404423 [details] [diff] [review] Proposed patch Really pushing approval request for this regression fix to the next branch release.
Attachment #404423 - Flags: approval1.9.2.1?
Attachment #404423 - Flags: approval1.9.2?
Blocks: 459457
Comment on attachment 404423 [details] [diff] [review] Proposed patch Moving approval request to 1.9.2.3; Dao, any objection to taking this on the branch?
Attachment #404423 - Flags: approval1.9.2.2? → approval1.9.2.3?
No, this is fine.
Comment on attachment 404423 [details] [diff] [review] Proposed patch Approved for 1.9.2.4, a=dveditz for release-drivers
Attachment #404423 - Flags: approval1.9.2.4? → approval1.9.2.4+
Pushed changeset 32f5a1c5d866 to releases/mozilla-1.9.2
status1.9.2: --- → .4-fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: