Closed Bug 522515 Opened 15 years ago Closed 11 years ago

"ASSERTION: null url in @font-face rule" with <base href="javascript:3">

Categories

(Core :: CSS Parsing and Computation, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jruderman, Assigned: jtd)

References

Details

(Keywords: assertion, crash, testcase)

Crash Data

Attachments

(4 files)

Attached file testcase (deleted) —
###!!! ASSERTION: null url in @font-face rule: 'face->mURI', file /Users/jruderman/central/layout/base/nsPresContext.cpp, line 1737
Attached file testcase 2 (deleted) —
Triggers the assertion above, plus: ###!!! ASSERTION: null font uri: 'aFontFaceSrc->mURI', file /Users/jruderman/central/layout/style/nsFontFaceLoader.cpp, line 233
Now that the patch in bug 633299 has landed, the first assertion is also in layout/style/nsFontFaceLoader.cpp.
Attached file testcase 3 (crashes) (deleted) —
Crash Signature: [@ operator==(gfxFontFaceSrc const&, gfxFontFaceSrc const&) ]
Keywords: crash
Severity: normal → critical
Simply omit null URL's from userfont src array. Still need to support other src lists items: @font-face { family: test; src: local(mytest), url(..funky..), url(..normal..); }
Attachment #802046 - Flags: review?(dbaron)
Comment on attachment 802046 [details] [diff] [review] patch, omit null urls from userfont src array r=dbaron, though I'd probably skip the "last" variable and just put that expression inside the () of RemoveElementAt.
Attachment #802046 - Flags: review?(dbaron) → review+
And https://hg.mozilla.org/integration/mozilla-inbound/rev/f9e8e8ce552c since a couple of crashtests were expecting to get stuck with this assertion, and were surprised when they no longer hit it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee: nobody → jdaggett
Blocks: 915440
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: