Closed
Bug 52885
Opened 24 years ago
Closed 23 years ago
automatic radio selection for reassign shouldn't trigger if new text is same as original owner or empty
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement, P3)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: jruderman, Assigned: caillon)
References
()
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
bbaetz
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
0. have javascript turned on
1. go to an open bug
2. change e-mail address in 'assignee' box just above 'commit'
3. notice that js automatically selects the 'reassign' box for you (good)
4. change your mind, and select "resolve bug" instead
5. clear e-mail address for 'reassign', or change back to original owner,
because you're worried that you might change something accidentally.
6. notice that js automatically selects the 'reassign' box for you (bad)
This is somewhere between minor and enhancement and "future me!!!".
Reporter | ||
Comment 1•24 years ago
|
||
Same for resolve as duplicate.
Comment 2•24 years ago
|
||
Although not impossible to solve, this would be a fair bit of work compared to
the existing code. Right now it works with a very simple "onChange" handler. If
you change that field, it selects it. It doesn't care what you change it to. To
pull this off, you'd have to move the onChange handler into a separate
subroutine, instead of having it all right in the INPUT tag. You would also need
an onLoad handler that grabbed the initial value of that field. Once it's
changed, the onChange handler would need to determine if it matched the initial
value or not before deciding to select it.
Comment 3•24 years ago
|
||
*** This bug has been marked as a duplicate of 76161 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
Comment 4•24 years ago
|
||
OK, apparently this is harder. We'll leave the duplicate issue over at bug
#76161 and keep this separate.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•24 years ago
|
Target Milestone: --- → Bugzilla 2.16
Assignee | ||
Comment 5•23 years ago
|
||
->New product Bugzilla and taking.
Assignee: tara → caillon
Status: REOPENED → NEW
Assignee | ||
Comment 6•23 years ago
|
||
Really moving this time :)
Status: NEW → ASSIGNED
Component: Bugzilla → Creating/Changing Bugs
Product: Webtools → Bugzilla
Version: other → unspecified
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Comment 8•23 years ago
|
||
I'm not sure what Dave was thinking of in his comments for this with the onload
stuff and separate subroutines, but this is a relatively simple patch which sets
the value of the assignee email into a JS var (since we're in JS anyway with the
onChange() handler), and then compare the newly entered value to the old value.
r= from someone? :)
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 9•23 years ago
|
||
Comment 10•23 years ago
|
||
Comment on attachment 47984 [details] [diff] [review]
Simpler, better patch.
r=kiko looks much better now, harmless fix.
Attachment #47984 -
Flags: review+
Comment 11•23 years ago
|
||
Applied to
http://bugs.async.com.br/show_bug.cgi?id=130
So whoever verifies can test the validity of the fix.
Assignee | ||
Comment 12•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #47983 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Attachment #47984 -
Attachment is obsolete: true
Comment 13•23 years ago
|
||
Comment on attachment 47985 [details] [diff] [review]
Third time's a charm! This also checks if the value is blank.
r=bbaetz, and tested on the given bugzilla installation
Attachment #47985 -
Flags: review+
Comment 14•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•