Closed Bug 53189 Opened 24 years ago Closed 24 years ago

Print dialog opens up twice when clicked on Print button triangle in composition toolbar

Categories

(Core :: DOM: Editor, defect, P3)

x86
All
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: shrir, Assigned: bugzilla)

References

Details

Attachments

(1 file)

builds: 2000091808m18, all platforms Steps: 1 Launch Composer 2 Click on the triangle below the Print button in COmposition Toolbar 3 Observe a Print dialog pop up. 4 Click on CANCEL to close it 5 Observe that another PRINT dialog pops up Expected: Print dialog should not open up twice
not mine --> don
Assignee: pinkerton → don
This also happens in MailNews. This seems to happen because the parent (the button) observes cmd_print and so does it's child (the menupopup). This works fine if I just remove observes="cmd_print" from the menupopup, since it's derived from the parent. reassigning to me
Assignee: don → blakeross
Attached patch patch (deleted) — Splinter Review
Are those <menuitems> shared by any other buttons or main menus? Could this break the print menu item?
no and no.
Status: NEW → ASSIGNED
Keywords: approval, patch, review
I believe this is because the oncommand event fires on the menuitem, and the event bubbles up to the button, and fires there too. This fix seems reasonable given that. a=ben.
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
this is not fixed on branch....
REOPENING...not fixed on branch or trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This will not be fixed on the branch, it is not rtm++. It is working fine for me on the trunk in all cases. Please doublecheck...
oops its fixed...my mistake..I was verifying the wrong trunk.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
verified in 10/26 trunbk build.
Status: RESOLVED → VERIFIED
No problem. If you want this fixed on the branch, feel free to nominate...but don't hold your breath.
*** Bug 57986 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: