Closed Bug 532400 Opened 15 years ago Closed 15 years ago

Add a .crash() method to the testplugin

Categories

(Core Graveyard :: Plug-ins, defect)

Other Branch
x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Whiteboard: [notacrash])

Attachments

(1 file, 2 obsolete files)

In order to test crash reporting for plugin processes, we should have a method on the testplugin that crashes.
Attached patch Add testplugin.crash(), rev. 0 (obsolete) (deleted) — Splinter Review
This adds a .crash() method to the testplugin which kinda works when you run `make mochitest-ipcplugins`. Unfortunately, the parent process crashes in the next test, probably because the plugin module is invalid but the plugin host doesn't know that.... that might be fixed, or at least helped, by bug 529005 jgriffin, this test should only be run when IPC plugins are enabled. Could you figure out a way to make that happen?
whoops, cc'ing jgriffin, please see comment 1
Attached patch Add testplugin.crash(), rev. 1 (obsolete) (deleted) — Splinter Review
Unfortunately there's no really slick way to exclude a mochitest based on a preference, so I've added an "ifdef MOZ_IPC" in the makefile, and a preference read in the test itself. Once OOPP are on by default, we can remove the preference read. Someday it would be nice to convert mochitest to a manifest-based framework, so that it can more intelligently select tests based on the characteristics of the software-under-test. I think this would be especially useful for dealing with mochitest on embedded devices. But not today...
Attachment #415651 - Attachment is obsolete: true
Attached patch Add testplugin.crash(), rev. 2 (deleted) — Splinter Review
Added a test for reloading, which should cause the plugin to be started over after a crash. I'll land this with bug 532751.
Attachment #415720 - Attachment is obsolete: true
Whiteboard: [notacrash]
Depends on: 533482
http://hg.mozilla.org/mozilla-central/rev/c228f7ad2a50 followup for build bustage: http://hg.mozilla.org/mozilla-central/rev/c15b2b4cfbf2 See also bug 533482. The test is currently disabled waiting on pluginhost changes, but I'm re-enabling it in that bug 532751
Depends on: 532751
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 535802
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: