Closed
Bug 532671
Opened 15 years ago
Closed 15 years ago
After a plugin crashes, calls on that plugin instance should fail gracefully
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
When a plugin crashes, ~PluginInstanceParent is called but NPP->pdata isn't cleared, so the plugin host continues to call NPP functions with a now-bogus pointer. Easy to fix by nulling out NPP->pdata when the plugin crashes and doing null-checks in the appropriate entry points.
Attachment #415869 -
Flags: review?(bent.mozilla)
|
Assignee | |
Comment 1•15 years ago
|
||
This is the same basic idea, this time for PluginModuleParent.
Attachment #415903 -
Flags: review?(bent.mozilla)
|
||
Updated•15 years ago
|
Attachment #415903 -
Flags: review?(bent.mozilla) → review+
|
|
||
Updated•15 years ago
|
Attachment #415869 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/projects/electrolysis/rev/a346a86b8d44
http://hg.mozilla.org/projects/electrolysis/rev/3eee2a0a8366
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Version: unspecified → Other Branch
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•