Closed
Bug 535850
Opened 15 years ago
Closed 15 years ago
sporadic failure in test_animLengthReadonly.xhtml | undefined - got 4.574999809265137, expected -100
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
(Keywords: intermittent-failure)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261164496.1261165987.25225.gz
Linux mozilla-central debug test mochitests-1/5 on 2009/12/18 11:28:16
s: moz2-linux-slave08
{
>46414 INFO Running /tests/content/svg/content/test/test_animLengthReadonly.xhtml...
>++DOMWINDOW == 125 (0xc834f88) [serial = 1176] [outer = 0xa6135c8]
>46415 INFO TEST-PASS | /tests/content/svg/content/test/test_animLengthReadonly.xhtml | undefined
>46416 ERROR TEST-UNEXPECTED-FAIL | /tests/content/svg/content/test/test_animLengthReadonly.xhtml | undefined - got 4.574999809265137, expected -100
}
Looks like randomorange, as the "guilty" changeset is completely unrelated:
http://hg.mozilla.org/mozilla-central/rev/cd6ffc0e2a4d
Assignee | ||
Comment 1•15 years ago
|
||
The test itself is here:
http://hg.mozilla.org/mozilla-central/file/0e6c2ecbb397/content/svg/content/test/test_animLengthReadonly.xhtml
{
36 function main() {
37 // Sanity check: check initial values
38 is(circle.cx.baseVal.value, -100);
39 is(circle.cx.animVal.value, -100);
}
The second is() check is failing, when checking "circle.cx.animVal.value", so it looks like our animation on that attribute (from="0" to="100" begin="1s; 10s") has already begun. I guess it took us slightly more than 1 second to call the "main()" load-handler?
Maybe we should change those time values to be larger (e.g. larger than the mochitest timeout cutoff), so that even under ridiculously-loaded conditions, we won't sporadically reach that time before calling main().
Assignee | ||
Updated•15 years ago
|
Assignee | ||
Comment 2•15 years ago
|
||
I just pushed a fix for a similar issue in a different test.
See bug 474049 comment 101.
Comment 3•15 years ago
|
||
Sounds good. I think in some other similar cases of random orange we've just moved the call to pauseAnimations() earlier and use setCurrentTime(0), like you've done in bug 474049 comment 101.
Assignee | ||
Comment 4•15 years ago
|
||
Ok -- I'll do something similar here when I get a chance. Assigning to myself so I don't forget about this. (feel free to steal though)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•15 years ago
|
||
Landed fix doing what Brian suggested in Comment 3:
http://hg.mozilla.org/mozilla-central/rev/7bee3d3a7cf2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 6•15 years ago
|
||
For the record, jwatt says we could also have fixed this by listening for "SVGLoad" event, rather than "load", here:
> 204 window.addEventListener("load", main, false);
The "SVGLoad" event is fired when the <svg> element loads, and hence is synced up with the beginning of the document timeline. The window's "load" event, on the other hand, can be fired a bit later on. (e.g. it waits for all remote scripts, images, etc. to be loaded)
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•