Closed Bug 53612 Opened 24 years ago Closed 23 years ago

"milestone url" is bad on delete component screen

Categories

(Bugzilla :: Administration, task, P3)

Sun
Solaris

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: blk, Assigned: jacob)

References

Details

Attachments

(1 file, 1 obsolete file)

I have Bugzilla 2.10 running on a rh60 system. When I go to the components menu, and pick a product/component, then click "Delete" for that component, I get values for all the Parts except for "Milestone URL." What shows up is a hyperlink text -- missing">missing, with a link to <FONT COLOR= It looks like it would be fine if only "milestoneurl" had another value, but it probably shouldn't break like this if it doesn't.
Whiteboard: 2.14
Whiteboard: 2.14 → 2.16
Assignee: tara → jake
I fixed this one as an incidental in bug 38922... still waiting for review. I'll take this so I can make a seperate patch if need be.
moving to real milestones...
Target Milestone: --- → Bugzilla 2.16
Summary: "milestone url" is bad on delete componant screen → "milestone url" is bad on delete component screen
*** Bug 86154 has been marked as a duplicate of this bug. ***
Gee... I thought I had already split this out of the other patch... guess I didn't. I will now :)
Keywords: patch, review
Attached patch patch (obsolete) (deleted) — Splinter Review
Status: NEW → ASSIGNED
-> Bugzilla product, Administration component.
Component: Bugzilla → Administration
Product: Webtools → Bugzilla
Whiteboard: 2.16
Version: other → unspecified
Comment on attachment 38677 [details] [diff] [review] patch r=gerv if you rename $milestoneurl to something more apt. Gerv
Attachment #38677 - Flags: review+
Attached patch patch v2 (deleted) — Splinter Review
Comment on attachment 38677 [details] [diff] [review] patch patch v2 (attachment 49025 [details] [diff] [review]) uses the variable name $milestonelink instead of $milestoneurl. It also makes basically the same change in editproducts.cgi.
Attachment #38677 - Attachment is obsolete: true
Comment on attachment 49025 [details] [diff] [review] patch v2 r=myk, and presumably r=gerv for the first review now that the variable has been renamed to "milestonelink", so patch has first and second reviews and I am checking it in. >+ my $milestonelink = $milestoneurl ? "<a href=\"$milestoneurl\">$milestoneurl</a>" >+ : "<font color=\"red\">missing</font>"; I must say I particularly like this way of formatting the "? :" operator. For a long time I have been searching for a good way of formatting this operator in situations where the operands are too long to fit on one line but too simple to make sense in an if-then-else block, and now I think I have found it.
Attachment #49025 - Flags: review+
This was checked in on 9/27.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: