Closed
Bug 53612
Opened 24 years ago
Closed 23 years ago
"milestone url" is bad on delete component screen
Categories
(Bugzilla :: Administration, task, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: blk, Assigned: jacob)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
myk
:
review+
myk
:
review+
|
Details | Diff | Splinter Review |
I have Bugzilla 2.10 running on a rh60 system.
When I go to the components menu, and pick a product/component, then click
"Delete" for that component, I get values for all the Parts except for
"Milestone URL." What shows up is a hyperlink text -- missing">missing, with a
link to <FONT COLOR=
It looks like it would be fine if only "milestoneurl" had another value, but it
probably shouldn't break like this if it doesn't.
Updated•24 years ago
|
Whiteboard: 2.14
Assignee | ||
Updated•24 years ago
|
Whiteboard: 2.14 → 2.16
Assignee | ||
Updated•24 years ago
|
Assignee: tara → jake
Assignee | ||
Comment 1•24 years ago
|
||
I fixed this one as an incidental in bug 38922... still waiting for review.
I'll take this so I can make a seperate patch if need be.
Updated•24 years ago
|
Summary: "milestone url" is bad on delete componant screen → "milestone url" is bad on delete component screen
Assignee | ||
Comment 4•23 years ago
|
||
Gee... I thought I had already split this out of the other patch... guess I
didn't. I will now :)
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Comment 6•23 years ago
|
||
-> Bugzilla product, Administration component.
Component: Bugzilla → Administration
Product: Webtools → Bugzilla
Whiteboard: 2.16
Version: other → unspecified
Comment 7•23 years ago
|
||
Comment on attachment 38677 [details] [diff] [review]
patch
r=gerv if you rename $milestoneurl to something more apt.
Gerv
Attachment #38677 -
Flags: review+
Assignee | ||
Comment 8•23 years ago
|
||
Assignee | ||
Comment 9•23 years ago
|
||
Comment on attachment 38677 [details] [diff] [review]
patch
patch v2 (attachment 49025 [details] [diff] [review]) uses the variable name $milestonelink instead of
$milestoneurl. It also makes basically the same change in editproducts.cgi.
Attachment #38677 -
Attachment is obsolete: true
Comment 10•23 years ago
|
||
Comment on attachment 49025 [details] [diff] [review]
patch v2
r=myk, and presumably r=gerv for the first review now that the variable
has been renamed to "milestonelink", so patch has first and second reviews
and I am checking it in.
>+ my $milestonelink = $milestoneurl ? "<a href=\"$milestoneurl\">$milestoneurl</a>"
>+ : "<font color=\"red\">missing</font>";
I must say I particularly like this way of formatting the "? :" operator.
For a long time I have been searching for a good way of formatting this
operator in situations where the operands are too long to fit on one line
but too simple to make sense in an if-then-else block, and now I think
I have found it.
Attachment #49025 -
Flags: review+
Assignee | ||
Comment 11•23 years ago
|
||
This was checked in on 9/27.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•