Closed Bug 537723 Opened 15 years ago Closed 15 years ago

Toolbar in compose window and addressbook is no longer unified in 3.2a1pre

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Nomis101, Assigned: mstange)

References

Details

Attachments

(2 files)

Attached image Screenshot of the problem (deleted) —
The appearance of the toolbar in the compose window and the addressbook looks not as it should. It looks OK in 3.1, see screenshot. I've only tested on Mac OS X. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20100104 Shredder/3.2a1pre
No longer blocks: CcMcBuildIssues
regression window: 20091230 trunk build --> OK 20091231 trunk build --> broken
With that range, gotta be bug 534170, but I sure don't see why.
Summary: Appearance of toolbar in compose window and addressbook is broken in 3.2a1pre → Toolbar in compose window and addressbook is no longer unified in 3.2a1pre
Bug 534170 removed ".toolbar-primary { -moz-appearance: -moz-mac-unified-toolbar; }" which was overriding "toolbar, toolbox { -moz-appearance: none; }" in messengercompose.css because of higher specificity.
Hm yes, its Bug 534170. If I revert it, than the trunk build is back to normal.
Blocks: 534170
(In reply to comment #3) > Bug 534170 removed ".toolbar-primary { -moz-appearance: > -moz-mac-unified-toolbar; }" which was overriding "toolbar, toolbox { > -moz-appearance: none; }" in messengercompose.css because of higher > specificity. Yes, thats it, I was able to fix it for the addressbook with toolbar { - -moz-appearance: none; + -moz-appearance: toolbar; background-color: transparent; background-image: none; } in addressbook.css. But if I do the same for messengercompose.css, than the toolbar looks OK, but the rest looks strange. I've also found an -moz-mac-unified-toolbar in preferences.css. Is this OK if it isn't used anymore on trunk?
Attached patch v1 (deleted) — Splinter Review
This works on trunk, but I'm not sure if it doesn't break in combination with 1.9.2.
Attachment #420912 - Flags: review?(philringnalda)
Doesn't seem to break with 1.9.2 - any feeling about what would break if it did?
The two failure cases I have in mind are 1. a toolbar that should be unified isn't, and 2. a toolbar that should be transparent has become dark gray (because of the removal of -moz-appearance: none). If that doesn't seem to be the case in a quick test then I think we're good. :)
Comment on attachment 420912 [details] [diff] [review] v1 Tried again, and if it breaks or even bends anything in 1.9.2, it's too subtle for my eyes to see. Thanks for fixing us up!
Attachment #420912 - Flags: review?(philringnalda) → review+
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: