Closed
Bug 53904
Opened 24 years ago
Closed 24 years ago
Cannot drag text in frames
Categories
(Core :: XUL, defect, P2)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla0.9.1
People
(Reporter: bugzilla, Assigned: alecf)
References
()
Details
(Whiteboard: fix in hand)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Build ID: just pulled
Text in frames is not draggable. Check out the URL and try to drag the text in
the right frame as an example; the drag session never begins.
Comment 1•24 years ago
|
||
brade did this work. there's nothing in the d&d code that would prevent it.
Assignee: pinkerton → brade
Comment 3•24 years ago
|
||
accepting this bug to get it off the bugzilla e-mail radar
Status: NEW → ASSIGNED
Comment 4•24 years ago
|
||
I narrowed this down to a tiny test case with only a few words in each of the 2
frames. I can't drag the text if it's in a frameset but I can if I load a frame
as the page (rather than the frameset). At this point I have no idea why this
would be broken. I don't see a drag starting at all. (btw, this is on Linux)
Reset target milestone.
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: Future → mozilla1.0
Reporter | ||
Comment 5•24 years ago
|
||
I think this was fixed with the dnd rewrite.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 6•24 years ago
|
||
reopening bug; I see this on Macintosh mozilla debug build from today.
Go to the above url
Select some of the text on the right side
Click/Drag this selection to a Composer window (nothing happens)
Click/Drag this selection to the Finder (an empty text clipping is created)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•24 years ago
|
||
reassign to pinkerton (who I think is working on D&D issues these days) since
I'll be going on maternity leave any day now...
Assignee: brade → pinkerton
Status: REOPENED → NEW
Assignee | ||
Comment 8•24 years ago
|
||
pink, feel free to assign this to me
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Comment 10•24 years ago
|
||
Reassigning to pchen, since I'm loading up alecf with mostly url bar stuff for
mozilla0.9. Marking nsbeta1+, mozilla0.9
Assignee | ||
Comment 11•24 years ago
|
||
actually, it looks like no text is draggable.
Summary: Cannot drag text in frames → Cannot drag text
Assignee | ||
Comment 12•24 years ago
|
||
Assignee | ||
Comment 13•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Keywords: helpwanted → patch
Whiteboard: fix in hand
Assignee | ||
Comment 15•24 years ago
|
||
fix is in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 16•24 years ago
|
||
Text in frames still isn't draggable. That's why I was confused earlier...it
wasn't working even before you added the anchorNode foo.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 17•24 years ago
|
||
dammit. ok moving to moz 0.9.1, fixing title again
Status: REOPENED → ASSIGNED
Summary: Cannot drag text → Cannot drag text in frames
Target Milestone: mozilla0.9 → mozilla0.9.1
Comment 18•24 years ago
|
||
as discussed in team meeting, moving all Nav+ team members nsbeta1+ P3 bugs from
mozilla0.9.1 to mozilla0.9.2.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Assignee | ||
Updated•24 years ago
|
Priority: P3 → P2
Target Milestone: mozilla0.9.2 → mozilla0.9.1
Assignee | ||
Comment 19•24 years ago
|
||
Assignee | ||
Comment 20•24 years ago
|
||
ok, the attached fix fixes the main problem in this bug - what was happening was
we were trying to retrieve the selection for the main content area
(window._content), even though the drag originated in a frame. It turns out you
can get to the originating drag area (i.e. the frame) from the event object,
aEvent.view.
while there, I looked for other code which assumed we were dealing with
window._content - sure enough I found some moderately broken code, and switched
it over to aEvent.view. This fixes the problem that if you dragged and then gave
up a drag of some text, it would try to load it in the main browser...
it still leaves out the problem that if you drag a link from one window or frame
into another frame, that it still loads at the toplevel, but that's a completely
different bug (i.e. this patch didn't make things any worse)
looking for r=/sr=
Keywords: patch
Whiteboard: fix in hand
Comment 22•24 years ago
|
||
r=timeless
Assignee | ||
Comment 23•24 years ago
|
||
fix is in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•