Closed Bug 53904 Opened 24 years ago Closed 24 years ago

Cannot drag text in frames

Categories

(Core :: XUL, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla0.9.1

People

(Reporter: bugzilla, Assigned: alecf)

References

()

Details

(Whiteboard: fix in hand)

Attachments

(3 files)

Build ID: just pulled Text in frames is not draggable. Check out the URL and try to drag the text in the right frame as an example; the drag session never begins.
brade did this work. there's nothing in the d&d code that would prevent it.
Assignee: pinkerton → brade
future
Keywords: helpwanted
Target Milestone: --- → Future
accepting this bug to get it off the bugzilla e-mail radar
Status: NEW → ASSIGNED
I narrowed this down to a tiny test case with only a few words in each of the 2 frames. I can't drag the text if it's in a frameset but I can if I load a frame as the page (rather than the frameset). At this point I have no idea why this would be broken. I don't see a drag starting at all. (btw, this is on Linux) Reset target milestone.
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: Future → mozilla1.0
I think this was fixed with the dnd rewrite.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
reopening bug; I see this on Macintosh mozilla debug build from today. Go to the above url Select some of the text on the right side Click/Drag this selection to a Composer window (nothing happens) Click/Drag this selection to the Finder (an empty text clipping is created)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
reassign to pinkerton (who I think is working on D&D issues these days) since I'll be going on maternity leave any day now...
Assignee: brade → pinkerton
Status: REOPENED → NEW
pink, feel free to assign this to me
wow, that was easy.
Assignee: pinkerton → alecf
Status: NEW → ASSIGNED
Keywords: nsbeta1
Reassigning to pchen, since I'm loading up alecf with mostly url bar stuff for mozilla0.9. Marking nsbeta1+, mozilla0.9
Keywords: nsbeta1nsbeta1+
Target Milestone: mozilla1.0 → mozilla0.9
actually, it looks like no text is draggable.
Summary: Cannot drag text in frames → Cannot drag text
Attached patch correctly find the first anchor (deleted) — Splinter Review
Attached patch better fix that fixes bug 75023 (deleted) — Splinter Review
Keywords: helpwantedpatch
Whiteboard: fix in hand
fix is in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Text in frames still isn't draggable. That's why I was confused earlier...it wasn't working even before you added the anchorNode foo.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
dammit. ok moving to moz 0.9.1, fixing title again
Status: REOPENED → ASSIGNED
Summary: Cannot drag text → Cannot drag text in frames
Target Milestone: mozilla0.9 → mozilla0.9.1
as discussed in team meeting, moving all Nav+ team members nsbeta1+ P3 bugs from mozilla0.9.1 to mozilla0.9.2.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Priority: P3 → P2
Target Milestone: mozilla0.9.2 → mozilla0.9.1
Keywords: patch
Whiteboard: fix in hand
Attached patch fix which handles frame issues (deleted) — Splinter Review
ok, the attached fix fixes the main problem in this bug - what was happening was we were trying to retrieve the selection for the main content area (window._content), even though the drag originated in a frame. It turns out you can get to the originating drag area (i.e. the frame) from the event object, aEvent.view. while there, I looked for other code which assumed we were dealing with window._content - sure enough I found some moderately broken code, and switched it over to aEvent.view. This fixes the problem that if you dragged and then gave up a drag of some text, it would try to load it in the main browser... it still leaves out the problem that if you drag a link from one window or frame into another frame, that it still loads at the toplevel, but that's a completely different bug (i.e. this patch didn't make things any worse) looking for r=/sr=
Keywords: patch
Whiteboard: fix in hand
r=timeless
fix is in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: