Closed Bug 546053 Opened 15 years ago Closed 12 years ago

Regression: Keyboard navigation in the Bookmark dialog is broken effective 14th July 2009

Categories

(Firefox :: Bookmarks & History, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
blocking1.9.2 --- needed
status1.9.2 --- wanted

People

(Reporter: jdiggs, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: access, regression)

Steps to reproduce: 1. Launch Firefox 2. Press Ctrl+D to bookmark the current page 3. Press Tab twice to move to the 'Show all the bookmarks folders' button 4. Press Space to activate that button 5. Focus will be in the list of folders. Arrow Up and Down. Expected results: Focus would remain in the list of folders. Actual results: Other widgets claim focus. Impact: Keyboard-only users have a difficult time navigating in this dialog. Those who also happen to be blind are finding it impossible to do so because it's just too confusing. Regression window: Fine through: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090713 Minefield/3.6a1pre Broken from the following build to the present: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090714 Minefield/3.6a1pre
Note that a very similar behavior can be seen in the 'Library' dialog that appears when you choose Organize Bookmarks. I've only been able to reproduce it in the tree on the left; not the list of folders on the right. The regression window is the same, however. For now, I'm going to assume that this is a variant of the same issue. If I'm wrong and you'd like me to open a new bug, please let me know. Thanks!
Blocks: orca
Reassigning to Bookmarks & History since it's their UI, and each UI piece has its own keyboard handling logic in some non-standard widget situations.
Component: Disability Access → Bookmarks & History
QA Contact: disability.access → bookmarks
Just a general comment here, one should really avoid non-standard keyboard logic at all costs. Builds prior to the one sited fir this bug worked fine in this bookmarks area. In the meantime, I had to downgrade to version 3.5.7 until this can be fixed.
Is any progress being made on this problem? I will not be upgrading Firefox until this matter can be corrected. With these newer versions, I cannot manage my bookmarks at all!
On my ArchLinux system, the packagers just pushed out Firefox 3.6.2. Alas, the bookmarks dialog is still broken! Do note that this dialog worked fine with versions in the 3.5.x range but as cited earlier in this bug report, keyboard navigation is impossible with these later versions. Will any attention be given to this matter???
Arch Linux is now using 3.6.3 and the bookmark organizer dialog is still broken!!! I say, it is unusable with a keyboard in its present state. Again, is anything being done about this serious regression??
Marco B, can you help triage this? (Hopefully it is an easy fix)
I also went and tried this in a Windows XP environment with latest production build of 3.6.3 and this same problem happens over there as well. So this does not seem to be platform specific.
Requesting blocking basd on the fact that this is a regression from Firefox 3.5.
blocking1.9.2: --- → ?
Keywords: regression
I'm able to reproduce this bug on windows xp as well, however it works couple times when I open bookbark dialog first time, and then it become broken. Also I get errors in error console. When directory tree appears: Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://browser/content/places/tree.xml :: load :: line 94" data: no] when dialog is closed Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://browser/content/places/treeView.js :: PTV_setTree :: line 1364" data: no] Can we get an attention from browser module peers to prevent us to dig through unfamiliar code? David and Marco, can you keep in mind anybody to cc to get a help?
(In reply to comment #10) > Can we get an attention from browser module peers to prevent us to dig through > unfamiliar code? David and Marco, can you keep in mind anybody to cc to get a > help? Yep did that in comment #7 ;) I'll cc a few more now. Hey folks, can we get this assigned?
blocking1.9.2: ? → needed
(In reply to comment #0) > Broken from the following build to the present: > Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090714 > Minefield/3.6a1pre Can someone just confirm that this broke between these two builds? http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/07/2009-07-13-03-mozilla-central/ http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/07/2009-07-14-03-mozilla-central/ That would give a regression range of: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b9012a18d2c6&tochange=9b4dd06e1c9d Nothing immediately obvious to me in that range...
sorry i can't handle this atm, btw looking at the range in comment 12 looks like Neil did some select/focus change there, that could maybe be related.
I thought I might offer a few more points of observation here. It seems that navigation jumps to the "More" button only when arrowing away from an actual bookmark and not a folder; I say this because apparently some people are unable to reproduce the problem. Though it happens for me on both ArchLinux 32 bit and Windows XP, some other folks seem to make it work fine with both platforms. I should also say that right now, I am running two self-contained Firefox folders in my local normal user account. One is 3.5.9 which works beautifully and the other is 3.6.3 which exhibits this on-going problem 100% of the time for me. I thought I would test the binaries as they come from your site in case there should be a problem with the ArchLinux binary package. But for me it makes no difference. I am running xulrunner 1.9.2.3 on my Arch system as yelp is depending on that package. I don't know if this additional information sheds any more light on the situation.
I can't recreated on trunk with Windows 7 Home Premium 64 bit but based on comment 10 I don't think we can rule out Win.
Blocks: 560198
I just installed the binary of firefox 3.6.5pre from nightly/mozilla-1.9.2 for 2010-05-08 Linux 32 bit and the problem still persists. I see that this bug is still not assigned. I still have severe problems with keyboard navigation in the library/organize bookmarks dialog. Any more ideas on how/when this can be fixed. As far as I'm concerned, the bookmarks dialog in mozilla-1.9.2 is completely broken and unusable!
I also went and retried the dialog obtained by pressing Control-D to save a bookmark and pressing the Show all folders button. I then navigate to the list of folders and use arrow keys to move down the list. Focus jumps to the Done button every time.
Ah, so this broken last July. Helps to list the year and not just the day, should update the summary to better reflect this bug.
(In reply to comment #18) > Ah, so this broken last July. Helps to list the year and not just the day, > should update the summary to better reflect this bug. I didn't file the original bug so don't think I can change the summary text. I tried but don't see any place for me to update. NOTE: This did begin in July 2009!
I still cannot use this dialog with current releases of FF 3.6+. I still must continue using Firefox 3.5.9 until this matter can be resolved. I am disappointed that no-one has assigned this bug. I don't know Firefox internals at all so am personally unable to debug this myself. So I am still using 3.5.9 as my current version of Firefox.
(In reply to comment #18) > Ah, so this broken last July. Helps to list the year and not just the day, My apologies. I figured that people would conclude that, since the 14th of July had not yet occurred in 2010, the breakage took place in the past rather than the future. However, given that one week from today it will be the 14th of July, I suppose putting the year in the summary makes sense.
Summary: Regression: Keyboard navigation in the Bookmark dialog is broken effective 14th July → Regression: Keyboard navigation in the Bookmark dialog is broken effective 14th July 2009
I still can't recreate this bug. Most recently I tried 3.6.7 on Ubuntu 9.10 (Karmic Koala) and numerous Windows versions (trying to confirm comment 10). (In reply to comment #20) > I still cannot use this dialog with current releases of FF 3.6+. I am sorry to hear this Steve. As an additional data point, would you be comfortable trying the latest FF 4 beta and reporting back? http://www.mozilla.com/en-US/firefox/beta/
(In reply to comment #22) > I still can't recreate this bug. /me wonders "How can he NOT?!?" and then has an 'aha' moment. David, what's the value of accessibility.browsewithcaret? If it is 'false' please change it to 'true' and re-attempt. Thanks!
I am happy to say that the dialog is working much better with FF 4 Beta3 from trunk July 22, 2010. At least the caret doesn't jump out of the list anymore. I just started working with this so not sure if remaining problems have to do with Orca specifically or not. I am having some problems when nesting down into sub folders and then arrowing up and down in the list but I probably need to spend more time to pin this down. I think when I right arrow to expand a tree node, I may be tossed into the detail pane and thus unable to navigate what I think I should. But the biggest problem I've been fighting for the past year seems to have gone away with this version.
Hey, I'm using 4.0 beta 10 and not seeing any issues, including the issue with subfolders. Can anyone else confirm? Or is this fixed?
Since I've been using the 4.0 betas, I have not experienced the above problems anymore. I sure hope they never come back.
Joanie, can you confirm please?
No longer blocks: 560198
closing as worksforme per comment #26 and comment #27. Please reopen the bug if you can see the issue.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.