Closed Bug 55286 Opened 24 years ago Closed 24 years ago

Composer: links to named anchor's with "umlaute" like ä ö ü won't work

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: staublis, Assigned: cmanske)

Details

Attachments

(2 files)

reproduce: start composer insert an named anchor with a name wich contains "umlaute" like "ä" "ö" or "ü". now insert a link to that anchor. view page with browser. ==> link to the anchor does not work. the problem seems to be in the link, caus it replaces "umlaute" egg: "ö" gets replaces with "Ã?¶" and the browser doesn't recognice this. mfg staubli (sorry for all my silly composer bugs, but at the moment im working with composer to creat a page for my boss, he wanted frontpage, but i didnt agree :)
over to editor where Composer bugs live.
Assignee: asa → beppe
Component: Browser-General → Editor
QA Contact: doronr → sujay
-> brade. More entity encoding fun.
Assignee: beppe → brade
Status: UNCONFIRMED → NEW
Ever confirmed: true
What character encoding are you using? Can you attach a sample file with this problem? p.s. Please keep filing bugs as you see issues that we need to address!
Keywords: dataloss, rtm
Whiteboard: [rtm NEED INFO]
Target Milestone: --- → M19
This appears to be some kind of weirdness in the Link dialog. Unfortunately, I don't think we'll be able to come up with a safe, easy fix before rtm'ing. Setting to Future, reassign to cmanske since he wrote the Link dialog. Workarounds include: don't open link dialog, reselect the anchor after opening link dialog, click cancel to link dialog, correct the link / anchor in the HTML Source view.
Assignee: brade → cmanske
Keywords: relnoteRTM
OS: Windows NT → All
Hardware: PC → All
Target Milestone: M19 → Future
Keywords: 4xp, helpwanted
Remving rtm from keywords
Whiteboard: [rtm NEED INFO]
rtm - this one and leave at future
Whiteboard: [rtm-]
Whiteboard: [rtm-] → [rtm-] relnote-user
The foreign characters seem ok (HTML source shows proper escape codes) in the document, in the attribute value text, such as in the <a name="... I could create a link to a named anchor with an umlauted "a", save the file, and the link did jump to the anchor when viewed in the Browser, although in debug build, it asserts: NS_ERROR("not a UTF8 string"). Back in Composer, viewing the link in the Link Properties dialog will mangle the umlauted "a". So my first question is: Are escaped characters allowed at all in URLs? If they are, then this bug is in some URL code and probably not the editor.
Target Milestone: Future → mozilla0.9
When viewing the test file, reduce window size so the anchor at the bottom is not visible, but the link at the top is. When you click on the link, it will scroll the window so the named anchor is visible. Load this into Composer and the bug is revealed by simply clicking on the link and then on the Link toolbar button to view in Link Properties dialog.
Status: NEW → ASSIGNED
Naoki: I was told that you have been dealing with character conversion issues in named anchors etc., so I added you to this bug. Well I just found the basic problem: If we get the "href" string from the <a> tag like this: globalElement.href, then the character is not converted correctly, but if we use: globalElement.getAttribute("href"), the conversion is correct!
Attached patch Fix for bug. (deleted) — Splinter Review
The bug I fixed was bug 58819. Non Latin1 anchors were not recognized even if they matched with a document charset. I fixed to treat them as UTF-8 first then fallback to a document charset. Here is spec. http://www.w3.org/TR/html4/appendix/notes.html#h-B.2.1.
Replacing kristif with robinf. Robin Foster-Clark is now the docs owner for things Composer.
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
checked in
Resolution: FIXED → ---
we need to mark this RESOLVED-FIXEd....the bug has no resolution...thanks!
Status: RESOLVED → REOPENED
Marking fixed
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
verified in 2/7 build. - created a test html file (see attachement) with mozilla composer {build id: 2001020720} on a winnt pc. - tested the file with mozilla: correct. - ie 5.0 handled the file allso correct.
Status: RESOLVED → VERIFIED
Whiteboard: [rtm-] relnote-user
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: