Spinning out the separate work from bug 338549. We need to hook up POP3 to the msgAsyncPrompt service so that the prompts will occur in serial fashion. Attachment 405043 [details] [diff] has an incomplete first version for this bug.

Work in progress - updated version of the attachment on bug 338549. Still have various issues to contend with including the code in send password/username and exit options in OnPromptStart.

Ok, I think this does all the necessary. It may be a bit raw still, I'm going to do a bit more testing in a while, but wanted to get this initial version up for you to start looking at. The unit tests pass and the best testing I've had to check the serial prompts is by having two 3 pane windows open on different accounts, and doing a get mail on each of them.

Canceling the pop3 password prompt brings up a dialog "error getting password", which it shouldn't. I think you need to propagate the fact that the user pressed cancel, like I had to do for IMAP. I tried bad passwords, and the "enter new password" stuff worked... logging instead of printf would be good here: - PR_LOG(POP3LOGMODULE, PR_LOG_MAX, ("GetPassword()")); - nsresult rv = NS_OK; + printf("current state %d\n", m_pop3ConData->next_state); + switch (m_pop3ConData->next_state)

Comment on attachment 440282 [details] [diff] [review] The fix minusing based on cancel issue.

Ok, I'd missed handling that cancel case, I've added a check now so the connection will just abort if the user hits cancel (like it used to).

this works better, definitely.

Checked in: http://hg.mozilla.org/comm-central/rev/2fb73ad3a589