Closed
Bug 562679
Opened 15 years ago
Closed 15 years ago
Land new Add-ons Manager on trunk
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a5
People
(Reporter: whimboo, Assigned: mossop)
References
Details
(Whiteboard: [rewrite])
Attachments
(2 files)
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Once all remaining P1 blockers (which I have added to the dependency list are done, we have to finally land the new Add-ons Manager code on trunk.
Dave, I believe you will work on that. I will set you as assignee for now.
Assignee | ||
Comment 1•15 years ago
|
||
This is now landed, we have a perf regression on OSX that I will be looking into over the next couple of days and then backing out if I don't resolve it.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 2•15 years ago
|
||
(In reply to comment #1)
> This is now landed, we have a perf regression on OSX that I will be looking
> into over the next couple of days and then backing out if I don't resolve it.
Pretty smooth landing, for the size of it. Not to suggest the perf regression is unimportant, but it seems we gain more than we lose by keeping it on trunk, and keeping the perf regression to a followup (since nothing actually broke).
Reporter | ||
Comment 3•15 years ago
|
||
Dave, am I correct when I say we do not have to run a backout? Can we start to mark all bugs with [fixed-in-addonsmgr] in the whiteboard entry as fixed now?
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> Dave, am I correct when I say we do not have to run a backout? Can we start to
> mark all bugs with [fixed-in-addonsmgr] in the whiteboard entry as fixed now?
The current situation is that unless I have resolved the Ts regression by Saturday then I will have to backout everything. I could go either way on marking the bugs at this point, but obviously if I mark them all as fixed then I'll have to reopen them all if I backout.
Reporter | ||
Comment 5•15 years ago
|
||
Ok, that makes sense.
Assignee | ||
Comment 6•15 years ago
|
||
In the event that we need to backout we need to also update removed-files. This should do it I believe based on comparing the windows zip files pre and post landing.
Attachment #442874 -
Flags: review?(robert.bugzilla)
Updated•15 years ago
|
Attachment #442874 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Backed out:
http://hg.mozilla.org/mozilla-central/rev/8a7a28c65fbd
http://hg.mozilla.org/mozilla-central/rev/1240ddeed985
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
bug# is wrong on http://hg.mozilla.org/mozilla-central/summary
Assignee | ||
Comment 9•15 years ago
|
||
And need to update removed-files.in again now that we've relanded
Attachment #444574 -
Flags: review?(robert.bugzilla)
Updated•15 years ago
|
Attachment #444574 -
Flags: review?(robert.bugzilla) → review+
Comment 10•15 years ago
|
||
Comment on attachment 444574 [details] [diff] [review]
new removed-files.in patch (landed)
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/e5117ef37402
Attachment #444574 -
Attachment description: new removed-files.in patch → new removed-files.in patch (landed)
Assignee | ||
Updated•15 years ago
|
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Reporter | ||
Comment 11•15 years ago
|
||
Looks like it will be sticky now. Nothing major appeared after its landing. The Ts regression is known and not related to our code. Lets mark this bug as verified now.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [rewrite]
You need to log in
before you can comment on or make changes to this bug.
Description
•