Specifically: nsCSSFrameConstructor::MaybeRecreateFramesForContent nsCSSFrameConstructor::PostRestyleEventCommon nsStyleChangeList::AppendChange

Maybe I'm missing something, but don't we pass text nodes to PostRestyleEventCommon via RecreateFramesForContent sometimes?

That's one thing I'll have to check on, yes. Note that PostRestyleEventCommon currently has this code: NS_ASSERTION(aContent->IsNodeOfType(nsINode::eELEMENT), "Shouldn't be trying to restyle non-elements directly"); which suggests to me that in fact RecreateFramesForContent is not called on textnodes at the moment.... ;)

Okay. I was thinking of ReframeTextIfNeeded, but I see that it calls ContentInserted directly.

I think nsStyleChangeList::AppendChange is in fact used for non-elements at the moment (with a reconstruct hint), at least at first glance, so not touching that for now.

Comment on attachment 445276 [details] [diff] [review] Part 1: change some presshell APIs r=dbaron

Comment on attachment 445277 [details] [diff] [review] Part 2: Change the restyle-event functions to take Element r=dbaron

Comment on attachment 445278 [details] [diff] [review] Part 3: use element up through where we actually restyle In RestyleLaterSiblings, maybe rename the variable from |child| to |sibling|? r=dbaron with that

> maybe rename the variable from |child| to |sibling|? Done locally.

Pushed: http://hg.mozilla.org/mozilla-central/rev/8d16c0b81bcb http://hg.mozilla.org/mozilla-central/rev/3d81d9823bda http://hg.mozilla.org/mozilla-central/rev/5b155fd15dae