Closed
Bug 562854
Opened 15 years ago
Closed 14 years ago
Double-click goes through buttons in the new add-ons manager
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b10
People
(Reporter: jruderman, Assigned: darktrojan)
References
Details
(Whiteboard: [rewrite])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100429 Firefox/3.7a5pre
Steps to reproduce:
1. Tools > Add-ons > Extensions.
2. Find an extension that's enabled.
3. Click the "Disable" button.
4. Quickly click the "Undo" button that appears in its place.
Result: I'm now at the details page for the extension.
Expected: Back to initial state.
Updated•15 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [rewrite]
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 498553 [details] [diff] [review]
patch
This doesn't seem to quite cover all the cases. I can still double click on the author link to get to the details view. Is there any way we can automatically test this?
Attachment #498553 -
Flags: review?(dtownsend) → review-
Assignee | ||
Comment 3•14 years ago
|
||
This patch also catches text links and situation where the UI changes between clicks (e.g. the Undo button which disappears).
I can't think of a good way to automate testing. Could write a mochitest I suppose but I don't think that it's worth it.
Attachment #498553 -
Attachment is obsolete: true
Attachment #499428 -
Flags: review?(dtownsend)
Comment 4•14 years ago
|
||
(In reply to comment #3)
> I can't think of a good way to automate testing. Could write a mochitest I
> suppose but I don't think that it's worth it.
As long as we have the possibility to create automated tests we appreciate to have any of those in the tree.
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #499428 -
Attachment is obsolete: true
Attachment #500292 -
Flags: review?(dtownsend)
Attachment #499428 -
Flags: review?(dtownsend)
Comment 6•14 years ago
|
||
Comment on attachment 500292 [details] [diff] [review]
patch v2, now with tests
This looks good however since you posted it browser_purchase.js added another case you need to fix. Do that quick correction and then this will be a quick r+ and be ready to land.
Attachment #500292 -
Flags: review?(dtownsend) → review-
Assignee | ||
Comment 7•14 years ago
|
||
Attachment #500292 -
Attachment is obsolete: true
Attachment #502151 -
Flags: review?(dtownsend)
Comment 8•14 years ago
|
||
Comment on attachment 502151 [details] [diff] [review]
patch v2, updated test
Approved to land after b9
Attachment #502151 -
Flags: review?(dtownsend)
Attachment #502151 -
Flags: review+
Attachment #502151 -
Flags: approval2.0+
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
Comment 10•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•