Closed
Bug 562922
Opened 15 years ago
Closed 14 years ago
Multiple entries of the same extension and theme appear if the installation/update is triggered more than once
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: tchung, Assigned: mossop)
References
Details
(Whiteboard: [AddonsRewriteTestday][rewrite][has patch])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
multiple addons in queue screenshot
If installing a traditional addon via AMO or websites, the new addons manager doesn't seem to detect if the addon has already been installed and queued up. We need a way to determine the addon is already there, and not keep writing entries into the queue.
* See screenshot
Repro:
1) install nightly Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
2) visit a AMO site and search for a compatible plugin (eg. Quick notes @ https://addons.mozilla.org/en-US/firefox/addon/13572)
3) click the Add to Firefox button, then the Install button on the popdown.
4) Repeat this step a few more times when completed
5) switch to about:addons, and verify Quick notes is duped a few times in the queue before restarting.
Expected:
- if the addon is already in the install queue, there shouldnt be multiple rows being written to it.
|
||
Comment 1•15 years ago
|
||
It's not only for installed addons but also for canceled installations. Duping to bug 558134.
|
|
||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 3•15 years ago
|
||
Sorry but bug 558134 is already marked as fixed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
||
Updated•15 years ago
|
Blocks: 550048
Status: REOPENED → NEW
Summary: Need detection if addon is already been installed but not yet restarted → Multiple entries of the same extension and theme appear if the installation is triggered more than once
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P2
|
||
Comment 4•15 years ago
|
||
Feels like something the API should be handling.
|
|
||
Updated•14 years ago
|
Summary: Multiple entries of the same extension and theme appear if the installation is triggered more than once → Multiple entries of the same extension and theme appear if the installation/update is triggered more than once
|
||
Comment 9•14 years ago
|
||
This is still happening.
|
||
Updated•14 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dtownsend
blocking2.0: ? → betaN+
|
|
Assignee | |
Comment 11•14 years ago
|
||
Simple approach, when an install starts check for pending installs of the same add-on in the same install location and cancel them.
Attachment #483680 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [AddonsRewriteTestday][rewrite] → [AddonsRewriteTestday][rewrite][has patch][needs review rs]
|
||
Comment 12•14 years ago
|
||
Comment on attachment 483680 [details] [diff] [review]
patch rev 1
>diff --git a/browser/base/content/test/browser_bug553455.js b/browser/base/content/test/browser_bug553455.js
>--- a/browser/base/content/test/browser_bug553455.js
>+++ b/browser/base/content/test/browser_bug553455.js
>@@ -543,19 +543,18 @@ function test_renotify_installed() {
> info("Timeouts after this probably mean bug 589954 regressed");
>
> // Wait for the complete notification
> wait_for_notification(function(aPanel) {
> let notification = aPanel.childNodes[0];
> is(notification.id, "addon-install-complete-notification", "Should have seen the second install complete");
>
> AddonManager.getAllInstalls(function(aInstalls) {
>- is(aInstalls.length, 2, "Should be two pending installs");
>+ is(aInstalls.length, 1, "Should be two pending installs");
Should be one pending install?
r=rstrong with that
Attachment #483680 -
Flags: review?(robert.bugzilla) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [AddonsRewriteTestday][rewrite][has patch][needs review rs] → [AddonsRewriteTestday][rewrite][has patch]
|
|
Assignee | |
Comment 13•14 years ago
|
||
This actually landed: http://hg.mozilla.org/mozilla-central/rev/efd0cb45eb37
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
|
||
Comment 14•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101025 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•