Closed Bug 5637 Opened 25 years ago Closed 25 years ago

releasing RDF observers in destructor

Categories

(Core Graveyard :: RDF, defect, P3)

x86
Windows 98
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jevering, Assigned: waterson)

Details

(Whiteboard: fix in hand, awaiting code review)

Attachments

(1 file)

Go to yahoo.com open sidebar open related links select one after the page loads, apprunner crashes. It appears that it is attempting access an already freed element. Stack trace: nsXULTreeElement::GetDatabase(nsXULTreeElement * const 0x03af6418, nsIRDFCompositeDataSource * * 0x0088f99c) line 35 + 24 bytes RDFTreeBuilderImpl::CheckRDFGraphForUpdates(nsIContent * 0x03b08cc0) line 456 + 62 bytes RDFTreeBuilderImpl::UpdateContainer(nsIContent * 0x03afa1e0) line 406 RDFTreeBuilderImpl::Notify(nsITimer * 0x03f70e50) line 669 TimerImpl::Fire(unsigned long 14596501) line 313 TimerImpl::ProcessTimeouts(unsigned long 14596501) line 187 FireTimeout(HWND__ * 0x00000000, unsigned int 275, unsigned int 260, unsigned long 14596501) line 101 + 9 bytes KERNEL32! bff72317() RAPTORBASE!
Status: NEW → ASSIGNED
Target Milestone: M5
Attached patch necessary fix (deleted) — Splinter Review
Summary: Selecting a related link from sidebar crashes apprunner → releasing RDF observers in destructor
Whiteboard: fix in hand, awaiting code review
Fix in hand: we were NS_RELEASE-ing RDF observers that we didn't own. A datasource only holds a weak reference to the observers that are observing it. Waiting for rjc and putterman to review diffs, which are attached above.
Diffs look good to me.
It looks good to me too.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
verified on windows 98 and NT sp4 with build 1999-04-30-08
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: