Closed
Bug 564114
Opened 15 years ago
Closed 14 years ago
Crash [@ nsINode::CompareDocumentPosition] passing null
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta2+ |
People
(Reporter: jruderman, Assigned: peterv)
References
Details
(4 keywords)
Crash Data
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•15 years ago
|
||
Before the crash:
###!!! ASSERTION: don't pass null: 'aOtherNode', file /Users/jruderman/central/content/base/src/nsGenericElement.cpp, line 662
Keywords: assertion
|
||
Updated•15 years ago
|
blocking2.0: --- → ?
|
Assignee | |
Comment 2•15 years ago
|
||
We used to throw NS_ERROR_INVALID_ARG for compareDocumentPosition(null). WebKit returns DOCUMENT_POSITION_DISCONNECTED. Should I just keep throwing NS_ERROR_INVALID_ARG?
Assignee: nobody → peterv
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a5
|
|
Assignee | |
Comment 3•15 years ago
|
||
(The spec doesn't mention this case at all)
I say throwing makes more sense. Similar to appendChild(nsnull)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Turns out I added a helper function on nsINode that checks for null arg, but forgot to switch the two callers to it (quickstubs and nsNode3Tearoff::CompareDocumentPosition).
Attachment #443894 -
Flags: review?(bzbarsky)
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 443894 [details] [diff] [review]
v1
r=bzbarsky
Attachment #443894 -
Flags: review?(bzbarsky) → review+
|
||
Updated•15 years ago
|
blocking2.0: ? → beta1+
|
|
||
Updated•14 years ago
|
blocking2.0: beta1+ → beta2+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Crash Signature: [@ nsINode::CompareDocumentPosition]
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•