Closed
Bug 565820
Opened 15 years ago
Closed 15 years ago
[FIX]Switch nsReferencedElement to use Element
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
It knows it has Elements anyway; this makes life a little simpler for some consumers.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #445273 -
Flags: review?(roc)
|
|
Assignee | |
Updated•15 years ago
|
Summary: [FIX]Switched nsReferencedElement to use Element. → [FIX]Switch nsReferencedElement to use Element
Comment on attachment 445273 [details] [diff] [review]
Like so
I think I'd prefer to have
typedef mozilla::dom::Element Element;
in classes that need it instead of writing "mozilla::dom::Element" all over the place, as a general rule. Does that sound reasonable?
Attachment #445273 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
|
||
Comment 4•15 years ago
|
||
Be careful with typedefs, they don't seem to always work on Windows.
using might be better. See for example bug 555573.
|
|
||
Comment 5•15 years ago
|
||
Though, bug 555573 had a bit different case. There the typedef was outside class
declaration.
We've been using in-class typedefs in media and layer code for a while now.
|
|
Assignee | |
Comment 7•15 years ago
|
||
I did run all this through the tryserver and it looks ok.
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•