Closed
Bug 568037
Opened 14 years ago
Closed 14 years ago
Adjust toolbar backgrounds and gradients for the new theme
Categories
(Firefox :: Theme, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #447338 -
Flags: review?(gavin.sharp)
Comment 1•14 years ago
|
||
I was looking for this bug. Glad to see it's not too far of off landing.
Comment 2•14 years ago
|
||
Is this only for Windows XP as is stated above (platform), or will this also implement the light bluish translucent/gradient toolbar for Windows 7/Vista as in the mockups?
Assignee | ||
Comment 3•14 years ago
|
||
Added "#navigator-toolbox:not([tabsontop="true"]) > #nav-bar + #customToolbars + #PersonalToolbar[collapsed="true"] + #TabsToolbar:last-child:not(:-moz-lwtheme)" to hide the background on the tab bar if tabs are on bottom, the bookmarks bar is hidden and neither custom toolbars nor extension toolbars have been added.
Attachment #447338 -
Attachment is obsolete: true
Attachment #447990 -
Flags: review?(gavin.sharp)
Attachment #447338 -
Flags: review?(gavin.sharp)
Comment 4•14 years ago
|
||
Since Alpha5 is going to be out in sometime, I think we should land this, since Aero without proper toolbar background doesn't look complete/nice.
Comment 5•14 years ago
|
||
Seems like this is the same as bug 560516?
Comment 7•14 years ago
|
||
Is some other bug blocking this?
Anyway, till this lands: http://userstyles.org/styles/26738
Comment 8•14 years ago
|
||
No, Gavin hasn't reviewed this patch yet.
Comment 9•14 years ago
|
||
Comment on attachment 447990 [details] [diff] [review]
patch
rs=me - I noticed that the background box doesn't have rounded borders and needs more spacing between it and the navigation bar in tabs-on-bottom mode, but I assume that will be addressed separately?
Attachment #447990 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> (From update of attachment 447990 [details] [diff] [review])
> rs=me - I noticed that the background box doesn't have rounded borders and
> needs more spacing between it and the navigation bar in tabs-on-bottom mode,
> but I assume that will be addressed separately?
Yes, we'll still iterate over this a few times.
Assignee | ||
Comment 11•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Comment 12•14 years ago
|
||
Looks great now... just one point though..
Should this:
#navigator-toolbox[tabsontop="true"] > toolbar:not(#toolbar-menubar):not(#TabsToolbar)
{
border-left: 1px solid ThreeDShadow;
border-right: 1px solid ThreeDShadow;
}
be:
#main-window:not([sizemode="maximized"]) #navigator-toolbox:not([tabsontop=true]) toolbar:not(#nav-bar):not(#toolbar-menubar)
{
border-left: 1px solid threedshadow !important;
border-right: 1px solid threedshadow !important;
}
so that the left and right borders on toolbars show up only when the windows is Not Maximized?
Assignee | ||
Comment 13•14 years ago
|
||
(In reply to comment #12)
Maybe. File a new bug, with screenshots?
Comment 14•14 years ago
|
||
Ok.. will do.
Comment 15•14 years ago
|
||
(In reply to comment #6)
> Related, not the same.
After seeing what this patch do, it is the same. I've filled bug exactly for this backgrounds.
Assignee | ||
Updated•14 years ago
|
Target Milestone: Firefox 3.7a5 → Firefox 3.7a6
You need to log in
before you can comment on or make changes to this bug.
Description
•