Closed Bug 568037 Opened 14 years ago Closed 14 years ago

Adjust toolbar backgrounds and gradients for the new theme

Categories

(Firefox :: Theme, enhancement)

All
Windows XP
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b1

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) (deleted) — Splinter Review
No description provided.
Attachment #447338 - Flags: review?(gavin.sharp)
I was looking for this bug. Glad to see it's not too far of off landing.
Is this only for Windows XP as is stated above (platform), or will this also implement the light bluish translucent/gradient toolbar for Windows 7/Vista as in the mockups?
Attached patch patch (deleted) — Splinter Review
Added "#navigator-toolbox:not([tabsontop="true"]) > #nav-bar + #customToolbars + #PersonalToolbar[collapsed="true"] + #TabsToolbar:last-child:not(:-moz-lwtheme)" to hide the background on the tab bar if tabs are on bottom, the bookmarks bar is hidden and neither custom toolbars nor extension toolbars have been added.
Attachment #447338 - Attachment is obsolete: true
Attachment #447990 - Flags: review?(gavin.sharp)
Attachment #447338 - Flags: review?(gavin.sharp)
Since Alpha5 is going to be out in sometime, I think we should land this, since Aero without proper toolbar background doesn't look complete/nice.
Seems like this is the same as bug 560516?
Related, not the same.
Blocks: 560516
Is some other bug blocking this? Anyway, till this lands: http://userstyles.org/styles/26738
No, Gavin hasn't reviewed this patch yet.
Comment on attachment 447990 [details] [diff] [review] patch rs=me - I noticed that the background box doesn't have rounded borders and needs more spacing between it and the navigation bar in tabs-on-bottom mode, but I assume that will be addressed separately?
Attachment #447990 - Flags: review?(gavin.sharp) → review+
(In reply to comment #9) > (From update of attachment 447990 [details] [diff] [review]) > rs=me - I noticed that the background box doesn't have rounded borders and > needs more spacing between it and the navigation bar in tabs-on-bottom mode, > but I assume that will be addressed separately? Yes, we'll still iterate over this a few times.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Looks great now... just one point though.. Should this: #navigator-toolbox[tabsontop="true"] > toolbar:not(#toolbar-menubar):not(#TabsToolbar) { border-left: 1px solid ThreeDShadow; border-right: 1px solid ThreeDShadow; } be: #main-window:not([sizemode="maximized"]) #navigator-toolbox:not([tabsontop=true]) toolbar:not(#nav-bar):not(#toolbar-menubar) { border-left: 1px solid threedshadow !important; border-right: 1px solid threedshadow !important; } so that the left and right borders on toolbars show up only when the windows is Not Maximized?
(In reply to comment #12) Maybe. File a new bug, with screenshots?
Ok.. will do.
Blocks: 553797
Depends on: 571660
(In reply to comment #6) > Related, not the same. After seeing what this patch do, it is the same. I've filled bug exactly for this backgrounds.
Depends on: 571662
Depends on: 571787
Target Milestone: Firefox 3.7a5 → Firefox 3.7a6
Depends on: 592669
Depends on: 592676
Depends on: 592677
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: