Closed
Bug 569138
Opened 15 years ago
Closed 14 years ago
Extension with empty minVersion and/or maxVersion breaks Add-ons Manager
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b1
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: whimboo, Assigned: mossop)
References
Details
(Whiteboard: [AddonsRewrite])
Attachments
(1 file)
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre (.NET CLR 3.5.30729)
While trying to verify bug 567184 I was playing with some of the extensions and their install.rdf files and have seen that extensions can break the complete Add-ons Manager when an empty minVersion and/or maxVersion field is specified.
<em:targetApplication>
<Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion></em:minVersion>
<em:maxVersion></em:maxVersion>
</Description>
</em:targetApplication>
After such an extension is modified on disk the Add-ons Manager doesn't show up any of the installed extensions.
Steps:
1. Install any extension
2. Edit its install.rdf file and remove the values for minVersion and/or maxVersion
3. Delete the extensions.sqlite
4. Restart Firefox
5. Open the Add-ons Manager
Reporter | ||
Comment 1•15 years ago
|
||
The error which is shown in the error console:
Error: ERROR addons.xpi: Error processing file changes: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: file:///C:/mozilla/bin/minefield/modules/XPIProvider.jsm :: DirInstallLocation_uninstallAddon :: line 5054" data: no]
Reporter | ||
Updated•15 years ago
|
Flags: in-testsuite?
Assignee | ||
Updated•14 years ago
|
blocking2.0: ? → final+
Assignee | ||
Comment 2•14 years ago
|
||
Forgot about this one, it was fixed by bug 570484. Should add a quick testcase for it though.
Assignee: nobody → dtownsend
Depends on: 570484
Flags: in-litmus-
Target Milestone: --- → mozilla1.9.3a6
Reporter | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•14 years ago
|
||
Some test cases for this and surrounding issues.
Attachment #454284 -
Flags: review?(robert.bugzilla)
Reporter | ||
Comment 4•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Attachment #454284 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Landed testcase: http://hg.mozilla.org/mozilla-central/rev/da19603c8e2b
Flags: in-testsuite? → in-testsuite+
Assignee | ||
Updated•14 years ago
|
Target Milestone: mozilla1.9.3b1 → mozilla1.9.3
Assignee | ||
Updated•14 years ago
|
Target Milestone: mozilla1.9.3 → mozilla1.9.3b1
You need to log in
before you can comment on or make changes to this bug.
Description
•