Closed Bug 569519 Opened 15 years ago Closed 6 years ago

Add additional classes to make UI more easily theme-able

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED INACTIVE
Tracking Status
blocking2.0 --- -

People

(Reporter: Unfocused, Unassigned)

References

Details

(Whiteboard: [AddonsRewrite])

Gathering feedback from people wanting to theme the new addons manager, there are a few cases where adding a class to some elements would make theming significantly easier. So far: * Addon item: Parent container of the icon * Addon item: Parent container of the details/control/status containers (Feel free to add to this list)
blocking2.0: --- → ?
I would also have some suggestions regarding Mozmill: * Give the top-level hbox an id or class * Boxes under search-list * label under search-filter * accessKeyParens looks like missing a 't' * entries under search-list-empty * First vbox under richlistitem of the list view * First label under creator * id for detail-basicinfo * vbox under detail-basicinfo * vbox and childrens under detail-desc (especially the grid) I also miss a couple of properties for the list items. Should this be part of another bug or can we also do it here? * id (extension id) * blocklisted / blocklistedsoft * description * providesUpdatesSecurely * type (how do we differentiate between normal extensions and jetpacks) * updateable * selected * version
Whiteboard: [rewrite] → [AddonsRewrite]
Version: unspecified → Trunk
I would not block the release on this
blocking2.0: ? → -
Dave, if we don't have some of those items listed in my comment implemented, it will be hard for us to write Mozmill tests. Can't we do that work once we have to update the XUL/CSS files in favor of the new design?
What about spacers that appear especially when viewing addon details? They are both called spacer.I would propose renaming: spacer > leftspacer spacer > righspacer That way theme makers can for example only hide rightspacer(i think this pushes version numbers to far right).
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.