Closed Bug 570953 Opened 14 years ago Closed 9 years ago

missing files in FTP listing of OpenVMS sites

Categories

(Core :: Networking: FTP, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: Pierre.Bru, Unassigned)

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729) Firefox does not list file/directory if their name/extension contains lowercase letters or ODS-5 extended filename. only ODS-2 compliant filenames are listed. see http://www.openvms.compaq.com/doc/73final/6536/6536pro_002.html#hfs_using_ch for a description of ODS-2 vs. ODS-5 filenames Reproducible: Always I enter this bug under winXP as it's the only platform I have to test it but I think the problem exists on all platforms.
Component: General → Networking: FTP
Product: Firefox → Core
QA Contact: general → networking.ftp
Can you point to a url showing the problem, please?
We are in a period where ftp is clearly deprecated and in general, making changes to the code is riskier than letting it ride unless there is a patch and reviewer available to make a good judgment about it. So I'm going to wontfix ftp bugs related to enhancements, interop errors, etc.. We will be better off putting our energy into including a different js based ftp stack.
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
> We are in a period where ftp is clearly deprecated [...] Many things can happen over time spans like eight years. > [...] unless there is a patch [...] It's been some years, so my memory is unreliable, but, as I recall, I took a quick look at the then-current Mozilla source, and failed to find the code which dealt with FTP file listings. If someone could point me to it, then I might be able to do something, but I probably lack the ambition to set up a whole Firefox build environment, so, most likely, someone else would need to do any build-and-test work. > [...] So I'm going to wontfix ftp bugs [...] That'd be a de jure "wontfix", more formal than the mere de facto "wontfix" which has been in effect, lo, these many years? Not having seen the bad code, I can't know how difficult/risky it would really be to fix this (relatively simple-looking) problem, but if you think that the code is sufficiently brittle that a fix would be unwise, then who am I to argue? It's only one man's opinion, but to a casual, outside observer, however, this does not speak well of the code quality.
Steven, the relevant code is, I expect, in http://mxr.mozilla.org/mozilla-central/source/netwerk/streamconv/converters/ParseFTPList.cpp and http://mxr.mozilla.org/mozilla-central/source/netwerk/streamconv/converters/nsFTPDirListingConv.cpp (which calls into ParseFTPList). The code _is_ pretty brittle for a few reasons, starting with the fact that there is no actual standard for FTP directory listings, so the code has to guess as to what the various parts of the line it gets from the server mean. That means that it's easy to fix a problem for one sort of FTP server but in the process break things for another FTP server... And of course it's C code parsing stuff, so you have to be really careful about buffer overruns and the like. That said, there are certainly VMS-specific bits in ParseFTPList, so it's possible that changing just those would not affect anything else, at least. And yes, we are officially putting FTP into "try to not touch it" mode. Some people are pushing for us to remove it altogether, for what it's worth....
You need to log in before you can comment on or make changes to this bug.