Closed Bug 5716 Opened 26 years ago Closed 24 years ago

[windows]shortcut key "Ctrl =" for Inc. Indent doesn't work

Categories

(Core :: DOM: Editor, defect, P4)

x86
Windows 95
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: teruko, Assigned: anthonyd)

References

Details

(Keywords: platform-parity)

(This bug imported from BugSplat, Netscape's internal bugsystem. It was known there as bug #314768 http://scopus.netscape.com/bugsplat/show_bug.cgi?id=314768 Imported into Bugzilla on 04/29/99 12:53) Tested 4.06 Win US RTM In the HTML composer, "Ctrl =" for Increase Indent does not work at all. If you select menu Format|Increase Indent, it increase indent. "Ctrl -" for Decrease Indent works fine. In MAC, the short cut key for Increase Indent does not work, either. In UNIX, there are no short cut key for Increase Indent.
assigning Germaine as QA Assigned to
set tfv to 5.0 since this doesn't appear to be a regression from prior versions of 4.0x. Set platform to all since we should unify this in 5.0.
*** Bug 316349 has been marked as a duplicate of this bug. ***
reset to P5; may be a candidate for LATERing
The Macintosh version of this bug is #316414 and it has already been fixed. Reassign this bug to cmanske for Windows work. Charley--please reassign to akkana (assuming we don't later this bug in the mean time).
Resolve this as LATER; we won't have time to fix in 5.0.
Hey! not so fast. This works fine in 5.0. Please test if bug exists before latering
Please check if this works for UNIX. It works for Mac and Windows now.
= and - accelerators are already hooked up on Unix, but the accelerator isn't listed on the menu item. I'll add that as soon as the tree opens. Marking fixed.
Status: RESOLVED → REOPENED
Priority: P5 → P4
Target Milestone: M6
I reopened this since Editor's shortcut key is not working at this moment in Seamonkey.
Assignee: akkana → cmanske
Status: REOPENED → NEW
UI issue -- are we going to implement this shortcut?
Target Milestone: M6 → M7
Milestone M6 seems overly optimistic since xpfe hasn't given us keyboard shortcut capability yet. Maybe M7?
Status: NEW → ASSIGNED
Even M7 is probably unrealistic! Will leave it there for now.
Target Milestone: M7 → M10
I don't see any point in hacking in more hard-coded key mappings that will be replaced by the "real" key mapping service that is supposed to be done by a layout person, but I don't think it is an assigned task! TODO: Find or create suitable bug and list it in the "depends on" field
Assignee: cmanske → brade
Status: ASSIGNED → NEW
OS: Windows 95 → All
Target Milestone: M10 → M9
reassigning this bug to myself since I'm working on keybindings. Reset to M9.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
This now works on Macintosh. It will work on other platforms when saari@netscape.com fixes the bugs on Windows/Linux.
Status: RESOLVED → REOPENED
Target Milestone: M9 → M10
I tested this in 8-16 Mac M9 build. This function works under Mac, but it does not work under Window and Linux. I need to reopen this until this works under Windows and Linux. I will move this to M10.
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen of thie bug.
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
QA Contact: gbrown → teruko
Resolution: --- → FIXED
this should be fixed now; change QA contact to teruko since the current setting isn't a valid e-mail address (gbrown)
Status: RESOLVED → REOPENED
I tested this in 9-24 Mac, Win32, and Linux build. This does not work, so I reopen this.
Resolution: FIXED → ---
Target Milestone: M10 → M11
m11
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Teruko--I think this has been fixed; could you please verify?
Blocks: 15693
Status: RESOLVED → REOPENED
I test this in 11-02-08 Win32, Mac, and Linux. I cannot find Increase Indent menu in Composer and Ctrl + = does not work. Kathy, is this sopposed to work?
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen of this bug.
Target Milestone: M11 → M12
moving this over to M12
Summary: Composer shortcut key "Ctrl =" for Inc. Indent doesn't work → [BETA] shortcut key "Ctrl =" for Inc. Indent doesn't work
Whiteboard: [BETA code cleanup]
Target Milestone: M12 → M14
moving to M14
Whiteboard: [BETA code cleanup] → [PRE-BETA]
Depends on: 13378
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
I think this was fixed with the latest round of keybinding efforts.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Shortcut key for Inc. Indent and Dec. Indent are working in Mac and Linux (Shortcut keys have been changed to Alt= and Alt-). However, they don't work in Windows. I tried "Ctl=" "Ctl-" and "Alt=""Alt-". Since this bug covers all platforms, I reopen this.
Keywords: beta1
OS: All → Windows 95
Hardware: All → PC
Summary: [BETA] shortcut key "Ctrl =" for Inc. Indent doesn't work → [pp][BETA] shortcut key "Ctrl =" for Inc. Indent doesn't work
This bug has become a Windows-specific bug. Change summary/platform/os. RodS has a fix for it.
Just checked in the fix.
rods checked in a fix for this; should be able to verify this today
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
I tested this in 2000020808 Win32 build in Win95J and Winnt 4.0. The short cut keys "Ctrl =" for Inc. Indent and "Ctrl-" for Dec. Indent do not work.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
cc frank; frank can you help look into this; it works on Mac with today's build. This sounds like a windows-only bug. This is NOT PDT+ so it isn't critical unless we know that the root cause is serious it is pretty low priority
I take out beta1 from Keywords.
Keywords: beta1
reassign to frank; Frank could you look at this and see what happens on Windows? This keybinding does work on Mac. Removing milestone.
Assignee: brade → ftang
Status: REOPENED → NEW
Summary: [pp][BETA] shortcut key "Ctrl =" for Inc. Indent doesn't work → [pp] shortcut key "Ctrl =" for Inc. Indent doesn't work
Whiteboard: [PRE-BETA]
Target Milestone: M14
we currenlty do not send out keypress for the following ctrl+- ctrl+= ctrl+; ctrl+' ctrl+, ctrl+. ctrl=/ and alt+~ Is this beta1 ?
Status: NEW → ASSIGNED
The cause is window does not send out keypress event for the key combination I mention above.
set it to M16
Target Milestone: M16
Keywords: pp
Summary: [pp] shortcut key "Ctrl =" for Inc. Indent doesn't work → shortcut key "Ctrl =" for Inc. Indent doesn't work
joki- can you help to fix this ?
Assignee: ftang → joki
Status: ASSIGNED → NEW
Maybe if Joki is busy, RodS can help out? :-)
Summary: shortcut key "Ctrl =" for Inc. Indent doesn't work → [windows]shortcut key "Ctrl =" for Inc. Indent doesn't work
Windows is now creating the proper "press" event for <ctrl>- <ctrl>= and <ctrl>; The editor still isn't executing the correct commands for indent and dedent, but that is a XUL keybinding issue.
reassign to anthonyd since he is working on a fix for this bug.
Assignee: joki → anthonyd
i COULDN'T GET IT CHECKED IN THIS MORNING BUT i HAVE ANOTHER FIX FOR THE WINDOW TOOLKIT PORTION, SHOULD GET IT IN TODAY.
From an e-mail message from rods to anthonyd: It's really a couple of things, there are a couple of keys where the windows native char code doesn't match the DOM spec so these need to be mapped. Then on Windows, native WM_CHAR events were causing Press events to be correctly generated for for '-' and '=' but not when the control key was held down. So the Pres events need to be synthesized in those cases.
hmmm, ctrl= now works, but now keyboard navigation fails, along with keyboard input.
my guess (without looking at the current code) is keyboard navigation is failing is due to the fact that both charcode and keycode are set. That may be causing this problem?
I did a fresh pull this morning and keyboard nav works fine and so does keyboard input. What specific problem are you seeing?
ok, this is getting a tad confusing between this bug and 38939. in 38939 keyboard navigation (along with pgup and pgdn) are working with rods latest checkin. but ctrl= is still not working. will continue to work on it. sorry if i confused the issue. Anthony
I have finally fixed it this time. The problem was the mapping from the native code to the VK codes need to be done in KeyDown not in the dispatch.
rods checkin fixes this beautifully. resolving.
Status: NEW → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
I verified this in 2000-05-16-09 Win32 build.
Status: RESOLVED → VERIFIED
Product: Browser and Composer Component: Composer Platform: PC Operating System: Windows 95 - OSR1 Build ID: Gecko/20010924 Netscape6/6.2 URL: Not Applicable Desciption: When I try to use these shortcuts(CTRL+= and CTRL+-)the text does not increase or decrease indent, but instead it actually increases or decreases the text size. Reproducibility: Every time Steps to Reproduce: 1. Open a new blank page to edit in Composer 2. Type in "Hello", and highlight it. 3. Hold down the CTRL button and press = (the text will get larger) 4. Hold down the CTRL button and press - (the text will get smaller) Actual Results: Here is the HTML code for CTRL+= : <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body> <big>Hello</big> </body> </html> CTRL+- : <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> </head> <body> <small>Hello</small> </body> </html> Expected Results: I expected these keyboard shortcuts to increase or decrease indent.
Please do not reopen fixed/verified bugs that were fixed/verified over 6 months ago. This particular bug was verified over a year ago. There are other open bugs on the issue of shortcut keys for indent/outdent as well as the conflict you mention above. In fact, ctrl-= will *not* be used in Composer soon because it can't be localized to other keyboards and other countries.
You need to log in before you can comment on or make changes to this bug.