Attempting to build today ends with [...] I:/comm-central/mailnews/base/src/nsMessengerOS2Integration.cpp: In constructor 'nsMessengerOS2Integration::nsMessengerOS2Integration()': I:/comm-central/mailnews/base/src/nsMessengerOS2Integration.cpp:77: error: 'MsgGetAtom' was not declared in this scope make.exe[5]: *** [nsMessengerOS2Integration.o] Error 1 which seems to be related to the check in from bug#570902, mainly a missing include.

Comment on attachment 450809 [details] [diff] [review] Add a missing include. I can't review this, I don't know .mm or this code all that well; my hand on the other bug was just in ifdef changing. The changes to this file were not that straightforward.

(In reply to comment #0) > Created an attachment (id=450809) [details] > Add a missing include. > > which seems to be related to the check in from bug#570902, mainly a missing > include. Dave, the checkin that missed to add nsMsgUtils.h to the includes in nsMessengerOS2Integration.cpp was http://hg.mozilla.org/comm-central/rev/49782a242a72

Comment on attachment 450809 [details] [diff] [review] Add a missing include. I think Neil is the one who should review this.

Comment on attachment 450809 [details] [diff] [review] Add a missing include. Given what the changeset that is reported to have broken this added, I'm happy to give this r/sr.

Sorry about that. I noticed OSX needed it, then later on I noticed Win needed it, and yet I still forgot about OS/2 :-( Thanks for the patch! Pushed changeset 4dce3652e487 to comm-central.

Why is the patch landing on comm-central so different than the one attached here ?

Umm it looks like Neil pushed part of Bug 377319 in the same push, I'm not sure if that was reviewed or not (the parts he pushed).