Closed Bug 573946 Opened 15 years ago Closed 15 years ago

Mac widget files #include "prlog.h" too late

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

Attached patch fix (deleted) — Splinter Review
I've been getting build errors where sCocoaLog is used in nsClipboard.mm but not defined anywhere. The problem is that we need to set FORCE_PR_LOG before the first #include of "prlog.h", and it seems with some of the retained layer patches, something changes to #include "prlog.h" before we set FORCE_PR_LOG. The easiest fix is just to move the #include of prlog.h up to the beginning of the cpp file.
Attachment #453340 - Flags: review?(mstange)
Attachment #453340 - Flags: review?(mstange) → review+
Whiteboard: [needs landing]
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Depends on: 669544
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: