Closed
Bug 579334
Opened 14 years ago
Closed 14 years ago
Async visits are ignoring a disabled history
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b2
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta2+ |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: privacy, regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Async visits are using canAddURI but it does not check isHistoryDisabled.
|
Assignee | |
Comment 3•14 years ago
|
||
I put this up pretty quickly, will need a tryserver run and more eyes.
Tests are mostly a partial copy of the existing one.
Getting feedback from Benjamin, he said he ad ideas for an orange we saw, so let's see if our ideas could be similar.
|
||
Comment 4•14 years ago
|
||
If this is going to make beta 2, it'll have to be reviewed and checked in by end of day today. Is that likely to happen?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #457922 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Comment 5•14 years ago
|
||
tryserver run was fine, so I'm positive we can do that.
|
||
Comment 6•14 years ago
|
||
(In reply to comment #4)
> If this is going to make beta 2, it'll have to be reviewed and checked in by
> end of day today. Is that likely to happen?
If you believe in magic (of the speedy review kind) :)
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 457922 [details] [diff] [review]
patch v1.0
>+++ b/toolkit/components/places/tests/browser/Makefile.in
>@@ -48,6 +48,8 @@ include $(topsrcdir)/config/rules.mk
> _BROWSER_FILES = \
> browser_bug399606.js \
> browser_visituri.js \
>+ browser_visituri_nohistory.js \
>+ browser_visituri_privatebrowsing.js \
> browser_settitle.js \
> $(NULL)
nit: tabs before, now spaces. Just be consistent (don't care which way you want to go)
>+++ b/toolkit/components/places/tests/browser/browser_visituri_nohistory.js
>+function waitForClearHistory(aCallback) {
nit: brace on new line (like every other function you declare)
>+++ b/toolkit/components/places/tests/browser/browser_visituri_privatebrowsing.js
>+function waitForClearHistory(aCallback) {
nit: brace on new line (like every other function you declare)
r=sdwilsh
Attachment #457922 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Attachment #457922 -
Attachment is obsolete: true
Attachment #457922 -
Flags: feedback?(webapps)
|
|
Assignee | |
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•