Closed Bug 5794 Opened 25 years ago Closed 23 years ago

[MAC]Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil

Categories

(SeaMonkey :: Build Config, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.0

People

(Reporter: sfraser_bugs, Assigned: peterv)

References

()

Details

(Keywords: platform-parity)

Attachments

(1 file)

I just lost about an hour of time with a broken build, becuase of this nasty hack of aliasing NGLayoutConfigInclude.h to MacConfigInclude.h. I happened to cancel the dist process half way, so failed to reach the last line where the old MacConfigInclude.h alias is replace by the NGLayoutConfigInclude.h one. We need to figure out: 1. If this hack is still needed 2. Why NGLayoutConfigInclude.h exists at all. It certainly violates the organization of config files that I started with. 3. Whether there are any commercial build implications in any of this.
Status: NEW → ASSIGNED
Target Milestone: M6
I agree it is evil. I lost some time on it one day as well.
Summary: Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil → [PP]Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil
Putting on [PP] radar.
Target Milestone: M6 → M7
Target Milestone: M7 → M15
Assignee: beard → dcone
Status: ASSIGNED → NEW
Mac specific issue. Reassigning to Don.
Status: NEW → ASSIGNED
Keywords: pp
Summary: [PP]Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil → [MAC]Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil
Waqar.. Can you look at this.. I don't understand much about this issue and you are closer to those who this effects.
Assignee: dcone → waqar
Status: ASSIGNED → NEW
Target Milestone: M15 → M17
Looking into it.
Status: NEW → ASSIGNED
mass re-assign of all bugs where i was listed as the qa contact
QA Contact: cyeh → chofmann
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
FOrgot to set the milestone.
Target Milestone: M17 → Future
bulk reassigning Waqar's bugs to Don.
Assignee: waqar → dcone
Status: ASSIGNED → NEW
I did a cross reference on NGLayoutConfigInclude.h, and I do believe its not used anylonger. I found one reference that was commented out. I think this issue was cleared up.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
This is not the case. See <http://lxr.mozilla.org/mozilla/source/build/mac/build_scripts/ MozillaBuildList.pm#520>
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Simon.. I think you should handle this.. I dont know very much about the Mac build system build scripts.
Assignee: dcone → sfraser
Status: REOPENED → NEW
Attached patch Remove NGLayoutConfigInclude.h (deleted) — Splinter Review
Taking. Patch removes NGLayoutConfigInclude.h. Everything still builds, MOZ_NGLAYOUT was removed a while ago ;-). I also checked for the include and MOZ_NGLAYOUT by searching my tree and by using http://lxr.mozilla.org/mozilla/. Looking for sr from Simon (patch includes commercial files).
Assignee: sfraser → peterv
Target Milestone: Future → mozilla1.0
Comment on attachment 71114 [details] [diff] [review] Remove NGLayoutConfigInclude.h Thank you Thank you Thank you. sr=sfraser
Attachment #71114 - Flags: superreview+
Comment on attachment 71114 [details] [diff] [review] Remove NGLayoutConfigInclude.h a=dbaron for trunk checkin
Attachment #71114 - Flags: approval+
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: