Closed
Bug 579747
Opened 14 years ago
Closed 14 years ago
Page Info - Permissions, Ineffectual on https: sites
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a3
People
(Reporter: therubex, Assigned: ewong)
References
()
Details
(Keywords: regression, Whiteboard: [good first bug])
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100718 SeaMonkey/2.1a3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100718 SeaMonkey/2.1a3pre
On an https: website, changes made via Page Info | Permissions are ineffectual.
Reproducible: Always
Steps to Reproduce:
1. Load http://bugzilla.mozilla.org
2. View | Page Info (or Ctrl+I) -> Permissions (tab)
3. Make a change
Actual Results:
Changes are not effectual.
Expected Results:
Changes should be effectual.
Broke between 2010 7/14 & 7/15.
Note that none of the square check boxes are checked (& you would expect them to be by default).
Error Console:
Error: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIPermissionManager.add]
Source file: chrome://navigator/content/pageinfo/permissions.js
Line: 175
Line 175:
permissionManager.add(gPermURI, aPartId, permission);
Context:
function onRadioClick(aPartId)
{
var permissionManager = Components.classes[PERMISSION_CONTRACTID]
.getService(nsIPermissionManager);
var radioGroup = document.getElementById(aPartId + "RadioGroup");
var id = radioGroup.selectedItem.id;
var permission = id.split('-')[1];
permissionManager.add(gPermURI, aPartId, permission);
}
> Ratty: There have been some recent changes in the Permissions code due to e10s (multiprocess tabs) landing. Perhaps something there broke us.
> Ratty: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2010-07-14&enddate=2010-07-16
> Ratty: probably Bug 564535 - permission manager needs to be remoted
Comment 1•14 years ago
|
||
Actually I think this is a regression from bug 539174, it probably just needs the security.js changes ported over.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ewong
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 2•14 years ago
|
||
Did we port this code over to Seamonkey? If it isn't, then it's probably not a regression from the Firefox change since the two Page Info instances are branched.
Comment 3•14 years ago
|
||
Tanner, you touched a properties file that is shared with Firefox but you didn't make the equivalent changes in the SeaMonkey XUL.
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #459994 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #459994 -
Flags: review? → review?(neil)
Updated•14 years ago
|
Attachment #459994 -
Flags: review?(neil) → review+
Comment 5•14 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/f502c0e0223e
Thanks Edmund!
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Keywords: helpwanted
Updated•14 years ago
|
Target Milestone: --- → seamonkey2.1a3
You need to log in
before you can comment on or make changes to this bug.
Description
•