Closed
Bug 581327
Opened 14 years ago
Closed 14 years ago
Lists of bugs (aka tags) are broken, because bug IDs are no longer split on commas
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: LpSolit, Assigned: mkanat)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
With the checkin of bug 67036, lists of bugs no longer work, because 1,2,3 is passed as is to Search.pm instead of being split on commas.
Bug ID: (is equal to any of the strings) 1, 1113, 1120 ( bugs.bug_id IN ('1,1113,1120') )
Note that quotes are wrong. With the patch backed out, you correctly get ('1','1113','1120') again.
Flags: blocking4.0+
Reporter | ||
Comment 1•14 years ago
|
||
Note that this breaks test_user_preferences.t, which is how I found this regression.
Assignee | ||
Comment 2•14 years ago
|
||
Ahh. Hmm. We'll have to limit the @values stuff to only being used for the multi-selects.
Might fix it a different way on trunk, though. We'll see.
Assignee | ||
Comment 3•14 years ago
|
||
All right, this fixes trunk.
In other news, WTG QA tests!! :-)
Assignee | ||
Comment 4•14 years ago
|
||
This fixes it for 4.0.
Attachment #459947 -
Attachment is obsolete: true
Attachment #459949 -
Flags: review?(LpSolit)
Reporter | ||
Comment 5•14 years ago
|
||
Comment on attachment 459949 [details] [diff] [review]
v1 (4.0)
>+ if ( $type eq 'anyexact'
>+ and ($field_obj->is_select or $field eq 'version'
>+ or $field eq 'target_milestone') )
I don't understand why "version" and "target_milestone" are so special. And where is "component"? Please give me some more info. :)
Reporter | ||
Comment 6•14 years ago
|
||
Also, is it intentional that the patch for tip has been marked as obsolete?
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #5)
> I don't understand why "version" and "target_milestone" are so special. And
> where is "component"? Please give me some more info. :)
Those are the only <select> fields that don't have FIELD_TYPE_SINGLE_SELECT set.
Assignee | ||
Updated•14 years ago
|
Attachment #459947 -
Attachment is obsolete: false
Assignee | ||
Comment 8•14 years ago
|
||
And yeah, it wasn't intentional that I marked the trunk patch obsolete. :-) I've un-obsoleted it now. :-)
Reporter | ||
Comment 9•14 years ago
|
||
Comment on attachment 459949 [details] [diff] [review]
v1 (4.0)
r=LpSolit
Attachment #459949 -
Flags: review?(LpSolit) → review+
Reporter | ||
Updated•14 years ago
|
Flags: approval4.0+
Flags: approval+
Assignee | ||
Comment 10•14 years ago
|
||
Thanks for the review, LpSolit! :-)
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Search.pm
Committed revision 7409.
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Search.pm
Committed revision 7353.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•