With the checkin of bug 67036, lists of bugs no longer work, because 1,2,3 is passed as is to Search.pm instead of being split on commas. Bug ID: (is equal to any of the strings) 1, 1113, 1120 ( bugs.bug_id IN ('1,1113,1120') ) Note that quotes are wrong. With the patch backed out, you correctly get ('1','1113','1120') again.

Note that this breaks test_user_preferences.t, which is how I found this regression.

Ahh. Hmm. We'll have to limit the @values stuff to only being used for the multi-selects. Might fix it a different way on trunk, though. We'll see.

All right, this fixes trunk. In other news, WTG QA tests!! :-)

This fixes it for 4.0.

Comment on attachment 459949 [details] [diff] [review] v1 (4.0) >+ if ( $type eq 'anyexact' >+ and ($field_obj->is_select or $field eq 'version' >+ or $field eq 'target_milestone') ) I don't understand why "version" and "target_milestone" are so special. And where is "component"? Please give me some more info. :)

Also, is it intentional that the patch for tip has been marked as obsolete?

(In reply to comment #5) > I don't understand why "version" and "target_milestone" are so special. And > where is "component"? Please give me some more info. :) Those are the only <select> fields that don't have FIELD_TYPE_SINGLE_SELECT set.

And yeah, it wasn't intentional that I marked the trunk patch obsolete. :-) I've un-obsoleted it now. :-)

Comment on attachment 459949 [details] [diff] [review] v1 (4.0) r=LpSolit

Thanks for the review, LpSolit! :-) Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Search.pm Committed revision 7409. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified Bugzilla/Search.pm Committed revision 7353.