The method imgIContainerObserver::frameChanged takes an argument 'aDirtyRect' to tell the observer the region that has changed. This argument isn't const right now, but it should be -- there's no reason the observer should want to modify the dirty-rect. Filing this bug on making this API change.

Here's the patch. Changes the API & the (many) implementations. For consistency, this patch also makes the change s/dirtyRect/aDirtyRect/ and s/container/aContainer/ in these implementations's function-signatures.

Comment on attachment 460287 [details] [diff] [review] fix v1 I feel a little dirty approving something I reviewed, but I'll get over it.

Some frameChanged implementations now call imgStatusTracker's frameChanged-notification methods now. (in particular, imgRequest::FrameChanged makes a call to imgStatusTracker::SendFrameChanged) So, these imgStatusTracker methods needs their aDirtyRect argument to be const as well. This followup fixes that.

This blocks a blocker, so it blocks too.

Comment on attachment 460287 [details] [diff] [review] fix v1 bholley pointed out that this technically requires SR since it's an interface change (even though it's just a trivial "add const to an argument") vlad, mind sr'ing? (note that bug 584841 stacks on top of this bug's patches)

Also: Don't worry if this requires a UUID rev (not sure if the 'const' addition to an argument would require that) -- I'll be landing it together with bug 584841, which already rev's the imgIContainer.idl UUID.

Landed: http://hg.mozilla.org/mozilla-central/rev/56c85516f8c2 http://hg.mozilla.org/mozilla-central/rev/3f389a6d5a6b