Closed
Bug 582601
Opened 14 years ago
Closed 14 years ago
Crash calling lookupPrefix on attribute node
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: peterv, Assigned: peterv)
References
(Blocks 1 open bug)
Details
(Keywords: crash, regression)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•14 years ago
|
||
Do you have a testcase associated with it? It seems to be wfm.
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #460898 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #1)
> Do you have a testcase associated with it?
The attribute node must not be attached to an element for the crash to happen. We deref null in that case.
blocking2.0: --- → ?
|
|
Assignee | |
Updated•14 years ago
|
Keywords: crash,
regression
|
||
Comment 4•14 years ago
|
||
Comment on attachment 460898 [details] [diff] [review]
v1
r=bzbarsky, though I wonder whether it would help to do a typedef in nsDOMAttributeMap so you don't have to have the namespace stuff twice.
Attachment #460898 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #1)
> It seems to be wfm.
It might be that we survive in optimized builds because AsElement is inline, the offset between Element and nsINode is 0 and all the function does is cast. In debug build we check a flag.
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•14 years ago
|
||
I'm going to open up this bug, since it seems like it only affects debug builds.
Group: core-security
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•