Closed
Bug 583616
Opened 14 years ago
Closed 14 years ago
icons on OS X bookmark toolbar not constrained to 16x16
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: Dolske, Assigned: mstange)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Bug 566034 turned on favicons for the OS X toolbar. Looks like we're not correctly limiting the size to 16x16, see bug 566034 comment 17 - 19.
STR:
1) Add http://www.stanford.edu/ to bookmark toolbar
2) Notice that icon is 16x32.
|
Reporter | |
Comment 1•14 years ago
|
||
Ick. The obvious change would be to set "max-height: 16px", but then the icons are again squished to 14px tall. The problem is that toolkit/themes/pinstripe/global/toolbarbutton.css sets 1px of top/bottom padding on the icon, so the correct min/max-height is actually 18px.
Probably should change the other CSS to be 1px of margin, or set the padding on the parent element, but I'm a bit loathe to be making/testing that as a broader change. But maybe I should. :(
Assignee: nobody → dolske
Attachment #461967 -
Flags: review?(dao)
|
Assignee | |
Comment 2•14 years ago
|
||
Or you could just set padding:0 only for this icon.
|
||
Comment 3•14 years ago
|
||
Attachment #461967 -
Flags: review?(dao)
|
||
Updated•14 years ago
|
blocking2.0: --- → ?
|
||
Updated•14 years ago
|
blocking2.0: ? → betaN+
|
|
||
Comment 5•14 years ago
|
||
I hit this with Google Reader :(
|
|
Assignee | |
Comment 6•14 years ago
|
||
Assignee: dolske → mstange
Attachment #461967 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #475500 -
Flags: review?(dao)
|
|
||
Updated•14 years ago
|
Attachment #475500 -
Flags: review?(dao) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [can land]
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
|
||
Updated•14 years ago
|
Whiteboard: [can land]
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•