Closed
Bug 584253
Opened 14 years ago
Closed 14 years ago
vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw @ [@ vp8_dequant_dc_idct_mmx ]
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: kinetik, Unassigned)
References
()
Details
(Keywords: crash, regression, Whiteboard: [crashkill])
Crash Data
See http://code.google.com/p/webm/issues/detail?id=136 for more details.
We'll need to update libvpx or cherry pick this patch to fix crashes in this function on CPUs that support MMX but not SSE.
Reporter | ||
Comment 1•14 years ago
|
||
A new stable release of libvpx is due "later this month", we can pick this fix up when updating to that: https://groups.google.com/a/webmproject.org/group/codec-devel/msg/5b37d49297476888
Comment 2•14 years ago
|
||
Getting it:
bp-0588612e-e8d8-4268-9279-1b8762100809
Reporter | ||
Comment 3•14 years ago
|
||
Cherry picking that patch is tricky because there have been other changes to the file since we last updated. I'd prefer Tim took care of it if we're going to take this approach.
Updating to the current git HEAD is going to need some work too. The status of our local patches against it are:
reduce-warnings-1 OK
splitmv-bounds FAIL
subpixel-qword OK FUZZY
subpixel-hidden FAIL
emptyif_warning UPSTREAM
solaris FAIL (minor, mostly OK FUZZY)
Reporter | ||
Updated•14 years ago
|
Keywords: crash
Summary: vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw → vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw @ [@ vp8_dequant_dc_idct_mmx ]
Whiteboard: [crashkill]
Reporter | ||
Updated•14 years ago
|
Updated•14 years ago
|
Severity: normal → critical
Keywords: regression
blocking2.0: ? → final+
Comment 5•14 years ago
|
||
Fixed by bug 593753.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Crash Signature: [@ vp8_dequant_dc_idct_mmx ]
You need to log in
before you can comment on or make changes to this bug.
Description
•