Closed Bug 584253 Opened 14 years ago Closed 14 years ago

vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw @ [@ vp8_dequant_dc_idct_mmx ]

Categories

(Core :: Audio/Video, defect)

x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: kinetik, Unassigned)

References

()

Details

(Keywords: crash, regression, Whiteboard: [crashkill])

Crash Data

See http://code.google.com/p/webm/issues/detail?id=136 for more details. We'll need to update libvpx or cherry pick this patch to fix crashes in this function on CPUs that support MMX but not SSE.
blocking2.0: --- → ?
Depends on: 577645
A new stable release of libvpx is due "later this month", we can pick this fix up when updating to that: https://groups.google.com/a/webmproject.org/group/codec-devel/msg/5b37d49297476888
Cherry picking that patch is tricky because there have been other changes to the file since we last updated. I'd prefer Tim took care of it if we're going to take this approach. Updating to the current git HEAD is going to need some work too. The status of our local patches against it are: reduce-warnings-1 OK splitmv-bounds FAIL subpixel-qword OK FUZZY subpixel-hidden FAIL emptyif_warning UPSTREAM solaris FAIL (minor, mostly OK FUZZY)
Keywords: crash
Summary: vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw → vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw @ [@ vp8_dequant_dc_idct_mmx ]
Whiteboard: [crashkill]
Severity: normal → critical
Keywords: regression
Depends on: 593753
Fixed by bug 593753.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Crash Signature: [@ vp8_dequant_dc_idct_mmx ]
You need to log in before you can comment on or make changes to this bug.