Closed
Bug 585728
Opened 14 years ago
Closed 14 years ago
Make Mozmill-test testFaviconInAutocomplete local
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u279076, Assigned: aaronmt)
References
Details
(Whiteboard: [litmus-data])
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
Module: testAwesomeBar/testFaviconInAutocomplete.js
Test-page: Use any 1 page from test-files/layout/mozilla*
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Assignee: aaron.train → nobody
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 1•14 years ago
|
||
cleanup + converts test to make use of local-content
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #468313 -
Flags: review?(anthony.s.hughes)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Returned the original style constant declaration as demonstrated in the original test, i.e., {url, string}. If the former (v1.0 patch) style (separated declaration) is recommended, I will change back.
Attachment #468313 -
Attachment is obsolete: true
Attachment #468318 -
Flags: review?(anthony.s.hughes)
Attachment #468313 -
Flags: review?(anthony.s.hughes)
Attachment #468318 -
Flags: review?(hskupin)
Attachment #468318 -
Flags: review?(anthony.s.hughes)
Attachment #468318 -
Flags: review+
|
||
Comment 3•14 years ago
|
||
Comment on attachment 468318 [details] [diff] [review]
Patch v1.1 - (default)
>-var setupModule = function(module)
>+var setupModule = function()
> {
nit: braces for functions.
>+ for each (var letter in LOCAL_TEST_PAGE.string) {
> locationBar.type(letter);
>- controller.sleep(gDelay);
>+ controller.sleep(200);
> }
[..]
>- controller.sleep(gDelay);
>+ controller.sleep(200);
We really should get rid of this sleep call. I would be ok with it here when you file a follow-up bug.
With that r=me.
Attachment #468318 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Fixes braces. Will follow up with a new bug for sleep()'s.
Attachment #468318 -
Attachment is obsolete: true
(In reply to comment #4)
> Created attachment 473320 [details] [diff] [review]
> Patch v1.2 - [nit fix] (default)
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/324c390de222
Please followup with 1.9.1 and 1.9.2 patches as necessary.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #473635 -
Flags: review?(anthony.s.hughes)
(In reply to comment #6)
> Created attachment 473635 [details] [diff] [review]
> Patch v1.2 - (1.9.2)
Landed on mozilla1.9.2:
http://hg.mozilla.org/qa/mozmill-tests/rev/b1e62ee744fb
One thing I noticed about this is that we dont make sure the Awesomebar Autocomplete is closed before ending this test. We should fix that -- I'll file a separate bug.
(In reply to comment #7)
> One thing I noticed about this is that we dont make sure the Awesomebar
> Autocomplete is closed before ending this test. We should fix that -- I'll
> file a separate bug.
Filed -> Bug 594891
|
|
Assignee | |
Comment 9•14 years ago
|
||
This test doesn't exist on 1.9.1, you can mark this as resolved fixed.
|
|
||
Comment 10•14 years ago
|
||
I don't see a difference between the tests for default and 1.9.2. Why we attach separate patches? The 1.9.1 part will be take care of on bug 553618.
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 11•14 years ago
|
||
Comment on attachment 473635 [details] [diff] [review]
Patch v1.2 - (1.9.2)
r+ prior to checkin but forgot to flip the flag. Doing so now.
Attachment #473635 -
Flags: review?(anthony.s.hughes) → review+
|
|
||
Comment 12•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•